Added tests (+ should actually work now)

Author: durkode

hooks/command

@@ -1,5 +1,5 @@
 #!/bin/bash
-set -eu -o pipefail
+set -eux -o pipefail
 
 # Reads either a value or a list from plugin config
 function plugin_read_list() {
@@ -41,7 +41,7 @@ if [[ -z ${files:-} ]] ; then
 fi
 
 echo "+++ Running shellcheck on ${#files[@]} files"
-if docker run --rm -v "$PWD:/mnt" --workdir "/mnt" koalaman/shellcheck "${options[@]}" "${files[@]}" ; then
+if docker run --rm -v "$PWD:/mnt" --workdir "/mnt" koalaman/shellcheck "${options[@]+${options[@]}}" "${files[@]}" ; then
   echo "Files are ok ✅"
 else
   exit 1

tests/run.bats

@@ -34,6 +34,57 @@ load '/usr/local/lib/bats/load.bash'
   unstub docker
 }
 
+@test "Shellcheck a single file with single option" {
+  export BUILDKITE_PLUGIN_SHELLCHECK_FILES_0="tests/testdata/subdir/llamas.sh"
+  export BUILDKITE_PLUGIN_SHELLCHECK_OPTIONS_0="--exclude=SC2086"
+
+  stub docker \
+    "run --rm -v $PWD:/mnt --workdir /mnt koalaman/shellcheck --exclude=SC2086 tests/testdata/subdir/llamas.sh : echo testing llamas.sh"
+
+  run "$PWD/hooks/command"
+
+  assert_success
+  assert_output --partial "testing llamas.sh"
+
+  unstub docker
+}
+
+@test "Shellcheck a single file with multiple options" {
+  export BUILDKITE_PLUGIN_SHELLCHECK_FILES_0="tests/testdata/subdir/llamas.sh"
+  export BUILDKITE_PLUGIN_SHELLCHECK_OPTIONS_0="--exclude=SC2086"
+  export BUILDKITE_PLUGIN_SHELLCHECK_OPTIONS_1="--format=gcc"
+  export BUILDKITE_PLUGIN_SHELLCHECK_OPTIONS_2="-x"
+
+  stub docker \
+    "run --rm -v $PWD:/mnt --workdir /mnt koalaman/shellcheck --exclude=SC2086 --format=gcc -x tests/testdata/subdir/llamas.sh : echo testing llamas.sh"
+
+  run "$PWD/hooks/command"
+
+  assert_success
+  assert_output --partial "testing llamas.sh"
+
+  unstub docker
+}
+
+@test "Shellcheck multiple files with multiple options" {
+  export BUILDKITE_PLUGIN_SHELLCHECK_FILES_0="tests/testdata/test.sh"
+  export BUILDKITE_PLUGIN_SHELLCHECK_FILES_1="tests/testdata/subdir/*"
+  export BUILDKITE_PLUGIN_SHELLCHECK_FILES_2="missing"
+  export BUILDKITE_PLUGIN_SHELLCHECK_OPTIONS_0="--exclude=SC2086"
+  export BUILDKITE_PLUGIN_SHELLCHECK_OPTIONS_1="--format=gcc"
+  export BUILDKITE_PLUGIN_SHELLCHECK_OPTIONS_2="-x"
+
+  stub docker \
+    "run --rm -v $PWD:/mnt --workdir /mnt koalaman/shellcheck --exclude=SC2086 --format=gcc -x tests/testdata/test.sh tests/testdata/subdir/llamas.sh tests/testdata/subdir/shell\ with\ space.sh' : echo testing test.sh"
+
+  run "$PWD/hooks/command"
+
+  assert_success
+  assert_output --partial "testing test.sh"
+
+  unstub docker
+}
+
 @test "Shellcheck failure" {
   export BUILDKITE_PLUGIN_SHELLCHECK_FILES_0="tests/testdata/subdir/llamas.sh"