Add some more detailed tests

Author: lox

.buildkite/pipeline.sh

@@ -1,5 +1,4 @@
 #!/bin/bash
-
 set -eu
 
 # If you build HEAD the pipeline.sh step, because it runs first, won't yet
@@ -22,7 +21,7 @@ steps:
 
   - label: run shellcheck
     plugins:
-      ${BUILDKITE_REPO}#${commit}:
+      shellcheck#${commit}:
         files:
           - hooks/*
           - buildkite/*.sh

hooks/command

@@ -19,17 +19,22 @@ function plugin_read_list() {
   fi
 }
 
+IFS=$'\n\t'
 files=()
 
-for pattern in $(plugin_read_list FILES) ; do
-  while IFS=$'\n' read -r line; do
-    files+=("$line")
-  done < <(ls -1 "$pattern" 2>/dev/null)
+# Evaluate all the globs and return the files that exist
+for file in $(plugin_read_list FILES) ; do
+  if [[ -e $file ]] ; then
+    files+=("$file")
+  fi
 done
 
 if [[ -z ${files:-} ]] ; then
   echo "No files found to shellcheck"
   exit 1
 fi
 
-docker run --rm -v "$PWD:/mnt" koalaman/shellcheck "${files[@]}"
+echo "+++ Running shellcheck on ${#files[@]} files"
+if docker run --rm -v "$PWD:/mnt" koalaman/shellcheck "${files[@]}" ; then
+  echo "Files are ok ✅"
+fi

tests/run.bats

@@ -2,23 +2,34 @@
 
 load '/usr/local/lib/bats/load.bash'
 
-export DOCKER_STUB_DEBUG=/dev/tty
-export LS_STUB_DEBUG=/dev/tty
+# export DOCKER_STUB_DEBUG=/dev/tty
 
 @test "Shellcheck a single file" {
-  export BUILDKITE_PLUGIN_SHELLCHECK_FILES_0="llamas.sh"
+  export BUILDKITE_PLUGIN_SHELLCHECK_FILES_0="tests/testdata/test.sh"
 
-  stub ls \
-    "-1 llamas.sh : echo llamas.sh"
+  stub docker \
+    "run --rm -v $PWD:/mnt koalaman/shellcheck tests/testdata/test.sh : echo testing test.sh"
+
+  run "$PWD/hooks/command"
+
+  assert_success
+  assert_output --partial "testing test.sh"
+
+  unstub docker
+}
+
+@test "Shellcheck multiple files" {
+  export BUILDKITE_PLUGIN_SHELLCHECK_FILES_0="tests/testdata/test.sh"
+  export BUILDKITE_PLUGIN_SHELLCHECK_FILES_1="tests/testdata/subdir/*"
+  export BUILDKITE_PLUGIN_SHELLCHECK_FILES_2="missing"
 
   stub docker \
-    "run --rm -v $PWD:/mnt koalaman/shellcheck llamas.sh : echo testing llamas.sh"
+    "run --rm -v $PWD:/mnt koalaman/shellcheck tests/testdata/test.sh tests/testdata/subdir/llamas.sh tests/testdata/subdir/shell\ with\ space.sh' : echo testing test.sh"
 
   run "$PWD/hooks/command"
 
   assert_success
-  assert_output --partial "testing llamas.sh"
+  assert_output --partial "testing test.sh"
 
-  unstub ls
   unstub docker
 }

tests/testdata/subdir/llamas.sh

@@ -0,0 +1,2 @@
+#!/bin/sh
+echo $UNDEFINED_VAR

tests/testdata/subdir/shell with a space.sh

@@ -0,0 +1,2 @@
+#!/bin/bash
+echo "Ain't nobody likes spaces in filenames"

tests/testdata/test.sh

@@ -0,0 +1,2 @@
+#!/bin/bash
+echo blah