fix: right place for evaluation dependency

Author: hurali97

gradle-plugins/react/brownfield/build.gradle.kts

@@ -94,7 +94,6 @@ dependencies {
     implementation(libs.agp)
     implementation(libs.common)
     implementation(libs.asm.commons)
-    implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3")
     implementation(libs.versioncompare)
 }
 

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/plugin/RNBrownfieldPlugin.kt

@@ -77,6 +77,12 @@ class RNBrownfieldPlugin
             artifactsResolver.taskDependencyFactory = taskDependencyFactory
             artifactsResolver.fileResolver = fileResolver
 
+            // Must run before processDefaultDependencies: ArtifactsResolver reads :expo's api configuration,
+            // which is only populated after the expo project is evaluated.
+            if (this.isExpoProject) {
+                project.evaluationDependsOn(EXPO_PROJECT_LOCATOR)
+            }
+
             val newArtifacts = artifactsResolver.processDefaultDependencies()
 
             val jniLibsProcessor = JNILibsProcessor()
@@ -140,13 +146,6 @@ class RNBrownfieldPlugin
                     aarLibraries.add(archiveLibrary)
                 }
 
-                /**
-                 * early return if aarLibraries is empty, no need to register/configure further tasks
-                 */
-                if (aarLibraries.isEmpty()) {
-                    return@all
-                }
-
                 /**
                  * Flat IDs to be put into the variant property, required for RClass Transformer
                  */
@@ -212,18 +211,13 @@ class RNBrownfieldPlugin
                 /** ===== processDataBinding ===== */
                 val bundleTask = variantTaskProvider.bundleTaskProvider(project, variant.name)
                 variantTaskProvider.processDataBinding(bundleTask, aarLibraries, variant.name)
+            }
 
+            project.afterEvaluate {
                 if (this.isExpoProject) {
-                    Logging.log("Expo project detected.")
-                    project.evaluationDependsOn(EXPO_PROJECT_LOCATOR)
-                }
-
-                project.afterEvaluate {
-                    if (this.isExpoProject) {
-                        ExpoPublishingHelper(
-                            brownfieldAppProject = project,
-                        ).afterEvaluate()
-                    }
+                    ExpoPublishingHelper(
+                        brownfieldAppProject = project,
+                    ).afterEvaluate()
                 }
             }
         }

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/plugin/RNSourceSets.kt

@@ -58,7 +58,7 @@ object RNSourceSets {
         // 2. Use the onVariants block to configure each variant
         componentsExtension.onVariants { variant ->
             // 3. Lazily configure the 'main' source set using .named()
-            androidExtension.sourceSets.named("main") { sourceSet ->
+            androidExtension.sourceSets.named(variant.name) { sourceSet ->
                 // Paths are collected and added, similar to your improved version
                 val bundlePathSegments =
                     listOf(

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/shared/ExplodeAarTask.kt

@@ -37,8 +37,7 @@ abstract class ExplodeAarTask : DefaultTask() {
         )
 
         val aarLibraries = mutableListOf<AndroidArchiveLibrary>()
-        val filteredArtifacts = artifacts.filter { it.bundleTaskName?.lowercase()?.contains(resolvedVariantName) == true }
-        filteredArtifacts.forEach { art ->
+        artifacts.forEach { art ->
             val archiveLibrary =
                 AndroidArchiveLibrary(
                     this.project,

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/shared/JsonInstance.kt

@@ -1,7 +1,5 @@
 package com.callstack.react.brownfield.shared
 
-import kotlinx.serialization.Serializable
-
 interface ModuleInfo {
     val moduleGroup: String
     val moduleName: String
@@ -16,7 +14,6 @@ interface ModuleInfo {
     val bundleTaskName: String?
 }
 
-@Serializable
 data class UnresolvedArtifactInfo(
     override val moduleGroup: String,
     override val moduleName: String,