Skip to content

Commit d671999

Browse files
Merge pull request #267 from checkout/fix/string-translation-missing
Fix missing strings translation
2 parents 6809f1c + 0c2c06c commit d671999

2 files changed

Lines changed: 19 additions & 4 deletions

File tree

woocommerce-gateway-checkout-com/assets/js/cko-frames-integration.js

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,16 @@ jQuery(function () {
7070
return logos;
7171
}
7272
var errors = {};
73-
errors["card-number"] = "Please enter a valid card number";
74-
errors["expiry-date"] = "Please enter a valid expiry date";
75-
errors["cvv"] = "Please enter a valid cvv code";
73+
if ( cko_frames_vars['card-number'] ) {
74+
errors["card-number"] = cko_frames_vars["card-number"];
75+
errors["expiry-date"] = cko_frames_vars["expiry-date"];
76+
errors["cvv"] = cko_frames_vars["cvv"];
77+
} else {
78+
errors["card-number"] = "Please enter a valid card number";
79+
errors["expiry-date"] = "Please enter a valid expiry date";
80+
errors["cvv"] = "Please enter a valid cvv code";
81+
}
82+
7683

7784
Frames.addEventHandler(
7885
Frames.Events.FRAME_VALIDATION_CHANGED,

woocommerce-gateway-checkout-com/woocommerce-gateway-checkout-com.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,14 @@ function cko_frames_js()
140140
{
141141
wp_register_script( 'cko-frames-script', 'https://cdn.checkout.com/js/framesv2.min.js', array( 'jquery' ) );
142142
wp_enqueue_script( 'cko-frames-script' );
143+
144+
$vars = array(
145+
'card-number' => esc_html__( 'Please enter a valid card number', 'wc_checkout_com' ),
146+
'expiry-date' => esc_html__( 'Please enter a valid expiry date', 'wc_checkout_com' ),
147+
'cvv' => esc_html__( 'Please enter a valid cvv code', 'wc_checkout_com' ),
148+
);
149+
150+
wp_localize_script( 'cko-frames-script', 'cko_frames_vars', $vars );
143151
}
144152

145153
/*
@@ -156,7 +164,7 @@ function cko_check_if_empty()
156164
&& $_POST['wc-wc_checkout_com_cards-payment-token'] !== 'new' ){
157165
// check if cvv is empty on checkout page
158166
if ( empty( $_POST['wc_checkout_com_cards-card-cvv'] ) ) {
159-
wc_add_notice( 'Please enter a valid cvv.', 'error' );
167+
wc_add_notice( esc_html__( 'Please enter a valid cvv.', 'wc_checkout_com' ), 'error' );
160168
}
161169
}
162170
}

0 commit comments

Comments
 (0)