Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

Commit 34ef84a

Browse files
committed
Remove unmaintained syslog-logger dependency
The syslog-logger gem hasn't been updated since 2014 and is unnecessary. The steno syslog sink only used it as a thin wrapper around the base syslog gem. Refactored to use syslog directly: - Use Syslog.open() directly instead of Syslog::Logger.new() - Update tests to use Syslog.close if Syslog.opened? - Remove syslog-logger from dependencies - Update CHANGELOG to reflect removal This reduces dependencies and removes reliance on an unmaintained gem while maintaining identical functionality.
1 parent bf4ac4e commit 34ef84a

4 files changed

Lines changed: 6 additions & 10 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212
- Updated development dependencies to latest versions
1313
- Added GitHub Actions for CI/CD
1414
- CI now tests all Ruby versions independently (fail-fast: false)
15+
- Refactored syslog sink to use syslog gem directly instead of unmaintained syslog-logger
1516

1617
### Added
1718
- Automated testing on multiple Ruby versions (3.0, 3.1, 3.2, 3.3, 3.4)
18-
- Ruby 3.4 compatibility: added syslog and syslog-logger gem dependencies for non-Windows platforms
19+
- Ruby 3.4 compatibility: added syslog gem dependency for non-Windows platforms
1920
- Dependabot configuration for automated dependency updates
2021
- GitHub Actions release workflow for automatic gem publishing
2122
- Release documentation (RELEASING.md)

lib/steno/sink/syslog.rb

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
require 'steno/sink/base'
33

44
require 'singleton'
5-
require 'syslog/logger'
5+
require 'syslog'
66

77
class Steno::Sink::Syslog < Steno::Sink::Base
88
include Singleton
@@ -29,9 +29,7 @@ def initialize
2929

3030
def open(identity)
3131
@identity = identity
32-
33-
Syslog::Logger.new(@identity)
34-
@syslog = Syslog::Logger.syslog
32+
@syslog = Syslog.open(@identity, Syslog::LOG_PID | Syslog::LOG_CONS)
3533
end
3634

3735
def add_record(record)

spec/unit/sink/syslog_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
describe '#add_record' do
1818
after do
19-
Syslog::Logger.syslog = nil
19+
Syslog.close if Syslog.opened?
2020
end
2121

2222
it 'appends an encoded record with the correct priority' do

steno.gemspec

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,7 @@ Gem::Specification.new do |gem|
3434
gem.add_development_dependency('rubocop-rake', '~> 0.6')
3535
gem.add_development_dependency('rubocop-rspec', '~> 3.0')
3636

37-
unless RUBY_PLATFORM =~ /mswin|mingw|cygwin/
38-
gem.add_dependency('syslog')
39-
gem.add_dependency('syslog-logger')
40-
end
37+
gem.add_dependency('syslog') unless RUBY_PLATFORM =~ /mswin|mingw|cygwin/
4138

4239
if RUBY_PLATFORM =~ /mswin|mingw|cygwin/
4340
gem.platform = Gem::Platform::CURRENT

0 commit comments

Comments
 (0)