Fix RuboCop violations and improve code quality

- Fix all RuboCop violations (Style, Layout, Lint)
- Use argument forwarding shorthand (...) for Ruby 3.0+
- Freeze constants for immutability
- Remove redundant require statements
- Use safe navigation operator where appropriate
- Replace string concatenation with interpolation
- Use RSpec predicate matchers
- Update .rubocop_todo.yml (reduced from 477 to 388 offenses)
- Bump Ruby version to 3.2 in .ruby-version

Author: johha

.rubocop.yml

@@ -1,8 +1,9 @@
 inherit_from: .rubocop_todo.yml
 
-require:
+plugins:
   - rubocop-rake
   - rubocop-rspec
 
 AllCops:
   NewCops: enable
+  SuggestExtensions: false

.rubocop_todo.yml

@@ -1,42 +1,18 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-03-18 15:28:40 UTC using RuboCop version 1.62.1.
+# on 2026-02-19 09:35:40 UTC using RuboCop version 1.84.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 6
-# Configuration parameters: EnforcedStyle, AllowedGems, Include.
+# Configuration parameters: EnforcedStyle, AllowedGems.
 # SupportedStyles: Gemfile, gems.rb, gemspec
-# Include: **/*.gemspec, **/Gemfile, **/gems.rb
 Gemspec/DevelopmentDependencies:
   Exclude:
     - 'steno.gemspec'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Severity, Include.
-# Include: **/*.gemspec
-Gemspec/RequireMFA:
-  Exclude:
-    - 'steno.gemspec'
-
-# Offense count: 1
-# Configuration parameters: Severity, Include.
-# Include: **/*.gemspec
-Gemspec/RequiredRubyVersion:
-  Exclude:
-    - 'steno.gemspec'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: symmetrical, new_line, same_line
-Layout/MultilineArrayBraceLayout:
-  Exclude:
-    - 'spec/unit/json_prettifier_spec.rb'
-
 # Offense count: 1
 Lint/BinaryOperatorWithIdenticalOperands:
   Exclude:
@@ -55,34 +31,6 @@ Lint/MissingSuper:
     - 'lib/steno/codec/json.rb'
     - 'lib/steno/sink/counter.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Lint/NonDeterministicRequireOrder:
-  Exclude:
-    - 'spec/spec_helper.rb'
-
-# Offense count: 8
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Lint/RedundantRequireStatement:
-  Exclude:
-    - 'lib/steno.rb'
-    - 'lib/steno/context.rb'
-    - 'lib/steno/logger.rb'
-    - 'lib/steno/record.rb'
-    - 'lib/steno/sink/base.rb'
-    - 'lib/steno/sink/eventlog.rb'
-    - 'lib/steno/sink/syslog.rb'
-    - 'spec/support/barrier.rb'
-
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AutoCorrect.
-Lint/UselessAssignment:
-  Exclude:
-    - 'bin/steno-prettify'
-    - 'lib/steno/json_prettifier.rb'
-    - 'spec/unit/sink/fluentd_spec.rb'
-
 # Offense count: 2
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
@@ -103,13 +51,6 @@ Metrics/MethodLength:
 Metrics/PerceivedComplexity:
   Max: 12
 
-# Offense count: 1
-# Configuration parameters: ForbiddenDelimiters.
-# ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
-Naming/HeredocDelimiterNaming:
-  Exclude:
-    - 'bin/steno-prettify'
-
 # Offense count: 2
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
 # AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
@@ -118,58 +59,16 @@ Naming/MethodParameterName:
     - 'lib/steno/logger.rb'
     - 'lib/steno/tagged_logger.rb'
 
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/BeEq:
-  Exclude:
-    - 'spec/unit/config_spec.rb'
-    - 'spec/unit/json_codec_spec.rb'
-
-# Offense count: 58
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: SkipBlocks, EnforcedStyle, OnlyStaticConstants.
-# SupportedStyles: described_class, explicit
-RSpec/DescribedClass:
-  Exclude:
-    - 'spec/unit/config_spec.rb'
-    - 'spec/unit/context_spec.rb'
-    - 'spec/unit/json_codec_spec.rb'
-    - 'spec/unit/json_prettifier_spec.rb'
-    - 'spec/unit/log_level_spec.rb'
-    - 'spec/unit/logger_spec.rb'
-    - 'spec/unit/record_spec.rb'
-    - 'spec/unit/sink/eventlog_spec.rb'
-    - 'spec/unit/sink/io_spec.rb'
-    - 'spec/unit/sink/syslog_spec.rb'
-    - 'spec/unit/steno_spec.rb'
-    - 'spec/unit/tagged_logger_spec.rb'
-
 # Offense count: 28
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
-  Max: 29
+  Max: 28
 
 # Offense count: 19
 RSpec/ExpectInHook:
   Exclude:
     - 'spec/unit/config_spec.rb'
 
-# Offense count: 10
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
-# Include: **/*_spec*rb*, **/spec/**/*
-RSpec/FilePath:
-  Exclude:
-    - 'spec/unit/config_spec.rb'
-    - 'spec/unit/json_codec_spec.rb'
-    - 'spec/unit/json_prettifier_spec.rb'
-    - 'spec/unit/log_level_spec.rb'
-    - 'spec/unit/logger_spec.rb'
-    - 'spec/unit/record_spec.rb'
-    - 'spec/unit/sink/counter_spec.rb'
-    - 'spec/unit/sink/fluentd_spec.rb'
-    - 'spec/unit/sink/io_spec.rb'
-    - 'spec/unit/tagged_logger_spec.rb'
-
 # Offense count: 57
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
@@ -214,17 +113,8 @@ RSpec/NoExpectationExample:
     - 'spec/unit/sink/syslog_spec.rb'
 
 # Offense count: 10
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
-# SupportedStyles: inflected, explicit
-RSpec/PredicateMatcher:
-  Exclude:
-    - 'spec/unit/logger_spec.rb'
-    - 'spec/unit/tagged_logger_spec.rb'
-
-# Offense count: 10
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
-# Include: **/*_spec.rb
+# Configuration parameters: CustomTransform, IgnoreMethods, IgnoreMetadata, InflectorPath, EnforcedInflector.
+# SupportedInflectors: default, active_support
 RSpec/SpecFilePathFormat:
   Exclude:
     - '**/spec/routing/**/*'
@@ -260,8 +150,10 @@ RSpec/VerifiedDoubles:
 
 # Offense count: 15
 # This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForClasses, EnforcedStyleForModules.
 # SupportedStyles: nested, compact
+# SupportedStylesForClasses: ~, nested, compact
+# SupportedStylesForModules: ~, nested, compact
 Style/ClassAndModuleChildren:
   Exclude:
     - 'lib/steno/codec/base.rb'
@@ -304,7 +196,7 @@ Style/Documentation:
 
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, AllowedMethods, AllowedPatterns.
+# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, Mode, AllowedMethods, AllowedPatterns.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   EnforcedStyle: unannotated
@@ -316,111 +208,9 @@ Style/FormatStringToken:
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/GlobalStdStream:
-  Exclude:
-    - 'bin/steno-prettify'
-    - 'lib/steno/config.rb'
-    - 'spec/unit/config_spec.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowSplatArgument.
-Style/HashConversion:
-  Exclude:
-    - 'lib/steno/config.rb'
-
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowedReceivers.
-# AllowedReceivers: Thread.current
-Style/HashEachMethods:
-  Exclude:
-    - 'lib/steno/logger.rb'
-    - 'lib/steno/sink/counter.rb'
-    - 'lib/steno/tagged_logger.rb'
-    - 'spec/unit/logger_spec.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/HashTransformKeys:
-  Exclude:
-    - 'lib/steno/config.rb'
-
-# Offense count: 1
-Style/MissingRespondToMissing:
-  Exclude:
-    - 'lib/steno/tagged_logger.rb'
-
-# Offense count: 7
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: literals, strict
-Style/MutableConstant:
-  Exclude:
-    - 'lib/steno/context.rb'
-    - 'lib/steno/json_prettifier.rb'
-    - 'lib/steno/logger.rb'
-    - 'lib/steno/sink/eventlog.rb'
-    - 'lib/steno/sink/syslog.rb'
-    - 'lib/steno/version.rb'
-
 # Offense count: 2
 # Configuration parameters: AllowedMethods.
 # AllowedMethods: respond_to_missing?
 Style/OptionalBooleanParameter:
   Exclude:
     - 'bin/steno-prettify'
-
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: short, verbose
-Style/PreferredHashMethods:
-  Exclude:
-    - 'lib/steno/json_prettifier.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle, AllowedCompactTypes.
-# SupportedStyles: compact, exploded
-Style/RaiseArgs:
-  Exclude:
-    - 'lib/steno/logger.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
-# AllowedMethods: present?, blank?, presence, try, try!
-Style/SafeNavigation:
-  Exclude:
-    - 'bin/steno-prettify'
-
-# Offense count: 10
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Mode.
-Style/StringConcatenation:
-  Exclude:
-    - 'lib/steno/codec/json.rb'
-    - 'lib/steno/json_prettifier.rb'
-    - 'lib/steno/logger.rb'
-    - 'lib/steno/tagged_logger.rb'
-    - 'spec/unit/json_prettifier_spec.rb'
-    - 'spec/unit/logger_spec.rb'
-    - 'steno.gemspec'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments.
-# AllowedMethods: define_method
-Style/SymbolProc:
-  Exclude:
-    - 'steno.gemspec'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
-# URISchemes: http, https
-Layout/LineLength:
-  Max: 128

.ruby-version

@@ -1 +1 @@
-2.7.8
+3.2.10

bin/steno-prettify

@@ -21,7 +21,7 @@ def prettify_io(io, prettifier, ignore_parse_error = false)
 
       prettified = prettifier.prettify_line(json)
       print prefix + prettified
-    rescue Steno::JsonPrettifier::ParseError => e
+    rescue Steno::JsonPrettifier::ParseError
       if ignore_parse_error
         print line
       else
@@ -43,14 +43,14 @@ def prettify_file(path, prettifier, ignore_parse_error = false)
 
   prettify_io(f, prettifier, ignore_parse_error)
 ensure
-  f.close if f
+  f&.close
 end
 
 excluded_fields = []
 ignore_parse_error = false
 
 option_parser = OptionParser.new do |op|
-  op.banner = <<~EOT
+  op.banner = <<~USAGE
     Usage: steno-prettify [OPTS] [FILE...]
 
     Parses json formatted log lines from FILE(s), or stdin,
@@ -65,7 +65,7 @@ option_parser = OptionParser.new do |op|
         Prettify contents of stdin.
 
     Options:
-  EOT
+  USAGE
 
   op.on('-h', '--help', 'Display help') do
     puts op
@@ -83,15 +83,15 @@ end
 
 option_parser.parse!(ARGV)
 
-STDOUT.sync = true
+$stdout.sync = true
 prettifier = Steno::JsonPrettifier.new(excluded_fields)
 
 inputs = ARGV.dup
 inputs << '-' if inputs.empty?
 
 inputs.each do |path|
   if path == '-'
-    prettify_io(STDIN, prettifier, ignore_parse_error)
+    prettify_io($stdin, prettifier, ignore_parse_error)
   else
     prettify_file(path, prettifier, ignore_parse_error)
   end

lib/steno.rb

@@ -1,5 +1,3 @@
-require 'thread'
-
 require 'steno/codec'
 require 'steno/config'
 require 'steno/context'

lib/steno/codec/json.rb

@@ -37,7 +37,7 @@ def encode_record(record)
 
     h['timestamp'] = Time.at(record.timestamp).utc.iso8601(6) if iso8601_timestamps?
 
-    Yajl::Encoder.encode(h) + "\n"
+    "#{Yajl::Encoder.encode(h)}\n"
   end
 
   def iso8601_timestamps?