Skip to content

Commit b1638d3

Browse files
committed
Test source_volume_name and source_volume_href on volume snapshot
1 parent 139a3a4 commit b1638d3

2 files changed

Lines changed: 29 additions & 1 deletion

File tree

cloudscale/datasource_cloudscale_volume_snapshot_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ func TestAccCloudscaleVolumeSnapshot_DS_Basic(t *testing.T) {
3636
"data.cloudscale_volume_snapshot.foo", "id", &snap.UUID),
3737
resource.TestCheckResourceAttr(
3838
"data.cloudscale_volume_snapshot.foo", "name", name1),
39+
resource.TestCheckResourceAttrPtr(
40+
"data.cloudscale_volume_snapshot.foo", "source_volume_name", &snap.SourceVolume.Name),
41+
resource.TestCheckResourceAttrPtr(
42+
"data.cloudscale_volume_snapshot.foo", "source_volume_href", &snap.SourceVolume.HREF),
3943
),
4044
},
4145
{

cloudscale/resource_cloudscale_volume_snapshot_test.go

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,10 @@ func TestAccCloudscaleVolumeSnapshot_Basic(t *testing.T) {
7979
resource.TestCheckResourceAttrPair(
8080
resourceName, "source_volume_uuid",
8181
"cloudscale_volume.source", "id"),
82+
resource.TestCheckResourceAttrPtr(
83+
resourceName, "source_volume_name", &sourceVolume.Name),
84+
resource.TestCheckResourceAttrPtr(
85+
resourceName, "source_volume_href", &sourceVolume.HREF),
8286
resource.TestCheckResourceAttr(
8387
resourceName, "size_gb", "50"),
8488
resource.TestCheckResourceAttr(
@@ -121,6 +125,10 @@ func TestAccCloudscaleVolumeSnapshot_UpdateName(t *testing.T) {
121125
resource.TestCheckResourceAttrPair(
122126
resourceName, "source_volume_uuid",
123127
"cloudscale_volume.source", "id"),
128+
resource.TestCheckResourceAttrPtr(
129+
resourceName, "source_volume_name", &sourceVolume.Name),
130+
resource.TestCheckResourceAttrPtr(
131+
resourceName, "source_volume_href", &sourceVolume.HREF),
124132
resource.TestCheckResourceAttr(
125133
resourceName, "size_gb", "50"),
126134
),
@@ -168,6 +176,10 @@ func TestAccCloudscaleVolumeSnapshot_import_basic(t *testing.T) {
168176
testAccCheckCloudscaleVolumeSnapshotExists(resourceName, &afterImport),
169177
resource.TestCheckResourceAttr(
170178
resourceName, "name", snapName),
179+
resource.TestCheckResourceAttrPtr(
180+
resourceName, "source_volume_name", &afterImport.SourceVolume.Name),
181+
resource.TestCheckResourceAttrPtr(
182+
resourceName, "source_volume_href", &afterImport.SourceVolume.HREF),
171183
),
172184
},
173185
{
@@ -208,6 +220,10 @@ func TestAccCloudscaleVolumeSnapshot_tags(t *testing.T) {
208220
Check: resource.ComposeTestCheckFunc(
209221
testAccCheckCloudscaleVolumeExists("cloudscale_volume.source", &sourceVolume),
210222
testAccCheckCloudscaleVolumeSnapshotExists(resourceName, &snapshot),
223+
resource.TestCheckResourceAttrPtr(
224+
resourceName, "source_volume_name", &sourceVolume.Name),
225+
resource.TestCheckResourceAttrPtr(
226+
resourceName, "source_volume_href", &sourceVolume.HREF),
211227
resource.TestCheckResourceAttr(
212228
resourceName, "tags.%", "2"),
213229
resource.TestCheckResourceAttr(
@@ -321,6 +337,14 @@ func TestAccCloudscaleVolumeSnapshot_MultipleOnSameVolume(t *testing.T) {
321337
resource.TestCheckResourceAttrPair(
322338
"cloudscale_volume_snapshot.snap2", "source_volume_uuid",
323339
"cloudscale_volume.source", "id"),
340+
resource.TestCheckResourceAttrPtr(
341+
"cloudscale_volume_snapshot.snap1", "source_volume_name", &sourceVolume.Name),
342+
resource.TestCheckResourceAttrPtr(
343+
"cloudscale_volume_snapshot.snap1", "source_volume_href", &sourceVolume.HREF),
344+
resource.TestCheckResourceAttrPtr(
345+
"cloudscale_volume_snapshot.snap2", "source_volume_name", &sourceVolume.Name),
346+
resource.TestCheckResourceAttrPtr(
347+
"cloudscale_volume_snapshot.snap2", "source_volume_href", &sourceVolume.HREF),
324348
resource.TestCheckResourceAttr(
325349
"cloudscale_volume_snapshot.snap1", "size_gb", "50"),
326350
resource.TestCheckResourceAttr(
@@ -385,4 +409,4 @@ resource "cloudscale_volume_snapshot" "basic" {
385409
}
386410
}
387411
`, rInt)
388-
}
412+
}

0 commit comments

Comments
 (0)