Ballot summaries (#2080)

* Add constant for Ballot Initiative Committee code, add more spacing for ballot initiative summaries

* Use white-space: pre-wrap for ballot initiative summaries - these are long and preserving whitespace is important for legibility

* Don't write DocumentText for bills if it is not present in the API - we are going to start manually (for now) overwriting DocumentText for bills with PDFs but not DocumentText, and we don't want the next scraper run to overwrite that data with null.

* Adding type assertion to test for type change

Author: Mephistic

components/bill/BillDetails.tsx

@@ -15,7 +15,10 @@ import { Back } from "components/shared/CommonComponents"
 import { useFlags } from "components/featureFlags"
 import { FollowBillButton } from "components/shared/FollowButton"
 import { PendingUpgradeBanner } from "components/PendingUpgradeBanner"
-import { isCurrentCourt } from "functions/src/shared"
+import {
+  currentBallotInitiativeCommittee,
+  isCurrentCourt
+} from "functions/src/shared"
 
 export const BillDetails = ({ bill }: BillProps) => {
   const { t } = useTranslation("common")
@@ -27,7 +30,7 @@ export const BillDetails = ({ bill }: BillProps) => {
   let isBallotMeasure = false
   const curComm = bill?.currentCommittee?.id
 
-  if (curComm == "SJ42") {
+  if (curComm === currentBallotInitiativeCommittee) {
     isBallotMeasure = true
   }
 

components/bill/Summary.tsx

@@ -17,7 +17,10 @@ import { SmartIcon } from "./SmartIcon"
 import { TestimonyCounts } from "./TestimonyCounts"
 import { BillProps } from "./types"
 import { BillTopic } from "functions/src/bills/types"
-import { currentGeneralCourt } from "functions/src/shared"
+import {
+  currentBallotInitiativeCommittee,
+  currentGeneralCourt
+} from "functions/src/shared"
 
 const Divider = styled(Col)`
   width: 2px;
@@ -30,6 +33,10 @@ const FormattedBillDetails = styled(Col)`
   white-space: pre-wrap;
 `
 
+const BallotSummaryRow = styled(Row)`
+  white-space: pre-wrap;
+`
+
 const SmartTag = ({ topic }: { topic: BillTopic }) => {
   return (
     <links.Internal
@@ -106,6 +113,8 @@ export const Summary = ({
   const handleHideBillDetails = () => setShowBillDetails(false)
   const billText = bill?.content?.DocumentText
   const hearingIds = bill?.hearingIds
+  const isBallotMeasure =
+    bill?.currentCommittee?.id === currentBallotInitiativeCommittee
 
   const { showLLMFeatures } = useFlags()
 
@@ -203,10 +212,20 @@ export const Summary = ({
               <hr className={`m-0 border-bottom border-2`} />
               <SmartDisclaimer />
             </>
+          ) : bill.summary !== undefined && isBallotMeasure ? (
+            <>
+              <hr className={`m-0 mb-3 border-bottom border-2`} />
+            </>
           ) : (
             <></>
           )}
-          <Row className="mx-1 mb-3">{bill.summary}</Row>
+          {bill.summary !== undefined && isBallotMeasure ? (
+            <BallotSummaryRow className={`mx-1 mb-3`}>
+              {bill.summary}
+            </BallotSummaryRow>
+          ) : (
+            <Row className="mx-1 mb-3">{bill.summary}</Row>
+          )}
           <Row className={`d-flex mx-0 my-1`} xs="auto">
             {bill.topics?.map(t => (
               <SmartTag key={t.topic} topic={t} />

components/db/bills.ts

@@ -33,7 +33,7 @@ export type BillContent = {
   Cosponsors: MemberReference[]
   LegislationTypeName: string
   Pinslip: string
-  DocumentText: string
+  DocumentText?: string
 }
 
 export type BillTopic = {

functions/src/bills/bills.ts

@@ -28,6 +28,10 @@ export const { fetchBatch: fetchBillBatch, startBatches: startBillBatches } =
         .getSimilarBills(court, id)
         .catch(logFetchError("similar bills", id))
         .then(bills => bills?.map(b => b.BillNumber).filter(isString) ?? [])
+      if (content.DocumentText == null) {
+        delete content.DocumentText
+      }
+
       const resource: Partial<Bill> = {
         content,
         history,

functions/src/shared/constants.ts

@@ -35,3 +35,7 @@ export const currentGeneralCourt = supportedGeneralCourts[0]
 
 export const isCurrentCourt = (courtNumber: number) =>
   courtNumber === currentGeneralCourt
+
+// Only applicable for court 193/194, but by the time we have another general court,
+// the full ballot initiative feature should be available and we can remove this check
+export const currentBallotInitiativeCommittee = "SJ42"

tests/unit/billdetail.test.tsx

@@ -162,7 +162,7 @@ describe("BillDetails", () => {
     const readMoreButton = screen.getByRole("button", { name: "Read more.." })
     expect(readMoreButton).toBeInTheDocument
     fireEvent.click(readMoreButton)
-    expect(screen.getByText(DocumentText)).toBeInTheDocument
+    expect(screen.getByText(DocumentText!)).toBeInTheDocument
   })
 
   // below test assumes mockBill contains a primary sponsor