refactor: clean up code style and improve type narrowing

Author: michalsn

rector.php

@@ -29,7 +29,6 @@
 use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
 use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
-use Rector\Php81\Rector\ClassMethod\NewInInitializerRector;
 use Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector;
 use Rector\PHPUnit\AnnotationsToAttributes\Rector\ClassMethod\DataProviderAnnotationToAttributeRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector;
@@ -103,11 +102,6 @@
         RemoveUnusedPrivateMethodRector::class => [
             __DIR__ . '/src/Commands/QueueWork.php',
         ],
-
-        // Skip for PayloadMetadata in the constructor
-        NewInInitializerRector::class => [
-            __DIR__ . '/src/Payloads/Payload.php',
-        ],
     ]);
 
     // auto import fully qualified class names

src/Commands/QueueStop.php

@@ -60,8 +60,7 @@ class QueueStop extends BaseCommand
      *
      * @var array<string, string>
      */
-    protected $options = [
-    ];
+    protected $options = [];
 
     /**
      * Actually execute a command.

src/Models/QueueJobFailedModel.php

@@ -46,10 +46,8 @@ public function __construct(?ConnectionInterface $db = null, ?ValidationInterfac
     {
         $this->DBGroup = config('Queue')->database['dbGroup'];
 
-        /**
-         * @var BaseConnection|null $db
-         */
         $db ??= Database::connect($this->DBGroup);
+        assert($db instanceof BaseConnection);
 
         // Turn off the Strict Mode
         $db->transStrict(false);

src/Models/QueueJobModel.php

@@ -50,10 +50,8 @@ public function __construct(?ConnectionInterface $db = null, ?ValidationInterfac
     {
         $this->DBGroup = config('Queue')->database['dbGroup'];
 
-        /**
-         * @var BaseConnection|null $db
-         */
         $db ??= Database::connect($this->DBGroup);
+        assert($db instanceof BaseConnection);
 
         // Turn off the Strict Mode
         $db->transStrict(false);