Extract precedence lists into static variables

Author: travkin79

org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/AbstractLsp4eLabelProvider.java

@@ -56,18 +56,28 @@ public abstract class AbstractLsp4eLabelProvider extends LabelProvider {
 		return LSPImages.imageDescriptorOverlayFromSymbolTag(SymbolTag.Deprecated);
 	}
 
+	private static final List<SymbolTag> VISIBILITY_PRECEDENCE = List.of(
+			SymbolTag.Public, SymbolTag.Protected, SymbolTag.Package,
+			SymbolTag.Internal, SymbolTag.File, SymbolTag.Private);;
+
 	/**
 	 * Returns a list of visibility {@link SymbolTag}s with decreasing precedence.
 	 * May be overridden by subclasses to change the visibility overlay icons shown.
 	 *
 	 * @return a list of visibility {@link SymbolTag}s
 	 */
 	protected List<SymbolTag> getVisibilityPrecedence() {
-		return List.of(
-				SymbolTag.Public, SymbolTag.Protected, SymbolTag.Package,
-				SymbolTag.Internal, SymbolTag.File, SymbolTag.Private);
+		return VISIBILITY_PRECEDENCE;
 	}
 
+	// In order to keep the number of overlay icons rather small in the UI, we do not show the following symbol tags:
+	// SymbolTag.Nullable, SymbolTag.NonNull, SymbolTag.Declaration, SymbolTag.Definition
+	private static final List<SymbolTag> ADDITIONAL_TAGS_PRECEDENCE = List.of(
+			SymbolTag.Static, SymbolTag.Final, SymbolTag.Abstract,
+			SymbolTag.Overrides, SymbolTag.Implements, SymbolTag.Virtual, SymbolTag.Sealed,
+			SymbolTag.Synchronized, SymbolTag.Transient, SymbolTag.Volatile,
+			SymbolTag.ReadOnly);
+
 	/**
 	 * Returns a list of {@link SymbolTag}s excluding visibility and deprecation tags with decreasing precedence.
 	 * May be overridden by subclasses to change the overlay icons shown in addition to visibility and deprecation.
@@ -78,13 +88,7 @@ protected List<SymbolTag> getVisibilityPrecedence() {
 	 * @return a list of {@link SymbolTag}s without visibility and deprecation tags
 	 */
 	protected List<SymbolTag> getAdditionalTagsPrecedence() {
-		// In order to keep the number of overlay icons rather small in the UI, we do not show the following symbol tags:
-		// SymbolTag.Nullable, SymbolTag.NonNull, SymbolTag.Declaration, SymbolTag.Definition
-		return List.of(
-				SymbolTag.Static, SymbolTag.Final, SymbolTag.Abstract,
-				SymbolTag.Overrides, SymbolTag.Implements, SymbolTag.Virtual, SymbolTag.Sealed,
-				SymbolTag.Synchronized, SymbolTag.Transient, SymbolTag.Volatile,
-				SymbolTag.ReadOnly);
+		return ADDITIONAL_TAGS_PRECEDENCE;
 	}
 
 	/**