Skip to content

Commit 677ac0b

Browse files
travkin79rubenporras
authored andcommitted
fix: Loading preference default for in-line renaming
Allows for customizing the default preference value with a plugin_customization.ini Work-around for issue #1494
1 parent 4e015da commit 677ac0b

2 files changed

Lines changed: 14 additions & 3 deletions

File tree

org.eclipse.lsp4e/plugin.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,9 @@
145145
<initializer
146146
class="org.eclipse.lsp4e.operations.linkedediting.LSPLinkedEditingBase$PreferenceInitializer">
147147
</initializer>
148+
<initializer
149+
class="org.eclipse.lsp4e.operations.rename.LSPInlineRenameLinkedMode$PreferenceInitializer">
150+
</initializer>
148151
</extension>
149152

150153
<extension point="org.eclipse.ui.genericeditor.foldingReconcilers">

org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/rename/LSPInlineRenameLinkedMode.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.eclipse.core.runtime.OperationCanceledException;
2828
import org.eclipse.core.runtime.Status;
2929
import org.eclipse.core.runtime.jobs.Job;
30-
import org.eclipse.core.runtime.preferences.InstanceScope;
30+
import org.eclipse.core.runtime.preferences.AbstractPreferenceInitializer;
3131
import org.eclipse.jdt.annotation.Nullable;
3232
import org.eclipse.jface.text.BadLocationException;
3333
import org.eclipse.jface.text.IDocument;
@@ -71,6 +71,15 @@
7171
public final class LSPInlineRenameLinkedMode {
7272

7373
private static final String INLINE_RENAME_PREFERENCE = "org.eclipse.lsp4e.inlineRename"; //$NON-NLS-1$
74+
private static final boolean INLINE_RENAME_ACTIVE_DEFAULT = true;
75+
76+
public static final class PreferenceInitializer extends AbstractPreferenceInitializer {
77+
@Override
78+
public void initializeDefaultPreferences() {
79+
final var store = LanguageServerPlugin.getDefault().getPreferenceStore();
80+
store.setDefault(INLINE_RENAME_PREFERENCE, INLINE_RENAME_ACTIVE_DEFAULT);
81+
}
82+
}
7483

7584
static boolean start(final IDocument document, final ITextViewer viewer, final int offset, final Shell shell) {
7685
if (!isInlineRenameEnabled()) {
@@ -121,8 +130,7 @@ protected IStatus run(final IProgressMonitor monitor) {
121130
}
122131

123132
private static boolean isInlineRenameEnabled() {
124-
final var prefs = InstanceScope.INSTANCE.getNode(LanguageServerPlugin.PLUGIN_ID);
125-
return prefs.getBoolean(INLINE_RENAME_PREFERENCE, true);
133+
return LanguageServerPlugin.getDefault().getPreferenceStore().getBoolean(INLINE_RENAME_PREFERENCE);
126134
}
127135

128136
private static @Nullable RefactoringStatus runPrepareRename(final LSPRenameProcessor processor) {

0 commit comments

Comments
 (0)