Skip to content

Commit e2a2cdd

Browse files
FlorianKroissrubenporras
authored andcommitted
fix: Handle Diagnostic with null severity as error
1 parent 621289b commit e2a2cdd

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/diagnostics/DiagnosticAnnotation.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919

2020
class DiagnosticAnnotation extends Annotation {
2121

22+
private static final String TYPE_INFO = "org.eclipse.ui.workbench.texteditor.info"; //$NON-NLS-1$
23+
private static final String TYPE_WARNING = "org.eclipse.ui.workbench.texteditor.warning"; //$NON-NLS-1$
24+
private static final String TYPE_ERROR = "org.eclipse.ui.workbench.texteditor.error"; //$NON-NLS-1$
2225
private final Diagnostic diagnostic;
2326
private final Function<Diagnostic, String> textComputer;
2427

@@ -30,10 +33,11 @@ public DiagnosticAnnotation(Diagnostic diagnostic, Function<Diagnostic, String>
3033
@Override
3134
public String getType() {
3235
return switch (diagnostic.getSeverity()) {
33-
case Error -> "org.eclipse.ui.workbench.texteditor.error"; //$NON-NLS-1$
34-
case Warning -> "org.eclipse.ui.workbench.texteditor.warning"; //$NON-NLS-1$
35-
case Information -> "org.eclipse.ui.workbench.texteditor.info"; //$NON-NLS-1$
36-
case Hint -> "org.eclipse.ui.workbench.texteditor.info"; //$NON-NLS-1$
36+
case Error -> TYPE_ERROR;
37+
case Warning -> TYPE_WARNING;
38+
case Information -> TYPE_INFO;
39+
case Hint -> TYPE_INFO;
40+
case null -> TYPE_ERROR;
3741
};
3842
}
3943

0 commit comments

Comments
 (0)