Skip to content

Commit 61cbeaf

Browse files
committed
Disable test_PlaceholderOnTopStackSwitch() on MacOS I-builds
PartOnTopManagerTest.test_PlaceholderOnTopStackSwitch() fails stabily in MacOS I-builds. Since its unclear what is wrong, the test is now disabled to reduce noise in test results. See: #3893
1 parent f2e2f88 commit 61cbeaf

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

tests/org.eclipse.e4.ui.tests/META-INF/MANIFEST.MF

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ Import-Package: jakarta.annotation,
3939
jakarta.inject,
4040
org.osgi.service.event,
4141
org.junit.jupiter.api;version="[5.14.0,6.0.0)",
42+
org.junit.jupiter.api.condition;version="[5.14.0,6.0.0)",
4243
org.junit.jupiter.api.extension;version="[5.14.0,6.0.0)",
4344
org.junit.platform.suite.api;version="[1.14.0,2.0.0)",
4445
org.opentest4j

tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/PartOnTopManagerTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import static org.junit.jupiter.api.Assertions.assertTrue;
2020

2121
import jakarta.inject.Inject;
22+
import org.eclipse.core.runtime.Platform;
2223
import org.eclipse.e4.ui.internal.workbench.PartOnTopManager;
2324
import org.eclipse.e4.ui.model.application.MApplication;
2425
import org.eclipse.e4.ui.model.application.ui.MContext;
@@ -33,6 +34,7 @@
3334
import org.eclipse.e4.ui.workbench.IWorkbench;
3435
import org.eclipse.e4.ui.workbench.modeling.EModelService;
3536
import org.eclipse.e4.ui.workbench.modeling.EPartService;
37+
import org.junit.jupiter.api.Assumptions;
3638
import org.junit.jupiter.api.Test;
3739
import org.junit.jupiter.api.extension.RegisterExtension;
3840

@@ -136,6 +138,8 @@ public void test_PartOnTopStackSwitch() {
136138

137139
@Test
138140
public void test_PlaceholderOnTopStackSwitch() {
141+
Assumptions.assumeFalse(Platform.OS.isMac() && System.getenv("ANT_HOME") != null, // 'ANT_HOME' is defined during I-builds, but not CI jobs on PRs
142+
"test fails stably on MacOS I-builds, its unclear how to fix it, see: https://github.com/eclipse-platform/eclipse.platform.ui/issues/3893");
139143
MWindow window = ems.createModelElement(MWindow.class);
140144
application.getChildren().add(window);
141145
application.setSelectedElement(window);

0 commit comments

Comments
 (0)