Skip to content

Commit e4e50ea

Browse files
committed
Disable test_PlaceholderOnTopStackSwitch() on MacOS
PartOnTopManagerTest.test_PlaceholderOnTopStackSwitch() fails stabily in MacOS I-builds. Since its unclear what is wrong, the test is now disabled to reduce noise in test results. See: #3893
1 parent e86d7f2 commit e4e50ea

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/PartOnTopManagerTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import static org.junit.jupiter.api.Assertions.assertTrue;
2020

2121
import jakarta.inject.Inject;
22+
import org.eclipse.core.runtime.Platform;
2223
import org.eclipse.e4.ui.internal.workbench.PartOnTopManager;
2324
import org.eclipse.e4.ui.model.application.MApplication;
2425
import org.eclipse.e4.ui.model.application.ui.MContext;
@@ -33,6 +34,7 @@
3334
import org.eclipse.e4.ui.workbench.IWorkbench;
3435
import org.eclipse.e4.ui.workbench.modeling.EModelService;
3536
import org.eclipse.e4.ui.workbench.modeling.EPartService;
37+
import org.junit.jupiter.api.Assumptions;
3638
import org.junit.jupiter.api.Test;
3739
import org.junit.jupiter.api.extension.RegisterExtension;
3840

@@ -136,6 +138,8 @@ public void test_PartOnTopStackSwitch() {
136138

137139
@Test
138140
public void test_PlaceholderOnTopStackSwitch() {
141+
// test fails stably on MacOS I-builds, its unclear how to fix it, see: https://github.com/eclipse-platform/eclipse.platform.ui/issues/3893
142+
Assumptions.assumeFalse(Platform.OS.isMac());
139143
MWindow window = ems.createModelElement(MWindow.class);
140144
application.getChildren().add(window);
141145
application.setSelectedElement(window);

0 commit comments

Comments
 (0)