Broken/missing Forms UI header colors

[HeikoKlare]

Forms UI, as used in the Manifest editor, used to look like this:

It looks as follows since

• Skip gradient image for flat look in FormHeading and CSS handler #3808

@vogella is that an intended effect of that PR? I have to admit that I did not expect such a change from the PR description and, personally, do not really like the missing highlight in the header. The tool icons for the ordering also look quite free floating now without the clear relation to the header that was previously obvious because of the background connecting them.

[vogella]

Indended yes, but as you disagree, I can restore the old background drawing.

[HeikoKlare]

I would appreciate if such a change was clearly mentioned in the PR. I did not expect any changes to a simple header background when the PR just states about gradient images. This will probably affect all consumers of the Forms UI, won't it? Can you share a link to the news entry explaining that change and how to adapt as a consumer?

You do not need to revert the change because of a single opinion. But would be interesting to hear other opinions on this kind of change (e.g., from @BeckerWdf).

[vogella]

Let's not revert it, I check tomorrow if I can restore the background with keeping the good parts. If not I revert

[merks]

Yes, there doesn’t need to be gradients but subtle shading to maintain the association and delineation is really badly needed. I definitely don’t like how the PDE editors look now! I look forward to improvements. Thanks for being responsive.

[vogella]

Will be back with #3808

I think if sections are styled we should also style the form header, but I put that into another PR.

[vogella]

Fixed, please test in tomorrows I-build

[BeckerWdf]

Fixed, please test in tomorrows I-build

A local test with your PR looked good in our product "ADT".

[vogella]

@BeckerWdf let me know if case you would like to try Form header styling (see screenshot 3). I have the change locally and I think it looks much better. If you want to test it, I can push it.