feat: extract plugin loader method for override (#246)

* feat: extract plugin loader method for override

* chore: fix load plugin order

Author: atian25

lib/loader/mixin/plugin.js

@@ -59,9 +59,10 @@ module.exports = {
   loadPlugin() {
     this.timing.start('Load Plugin');
 
+    this.lookupDirs = this.getLookupDirs();
     this.allPlugins = {};
-    this.appPlugins = this.loadAppPlugins();
     this.eggPlugins = this.loadEggPlugins();
+    this.appPlugins = this.loadAppPlugins();
     this.customPlugins = this.loadCustomPlugins();
 
     this._extendPlugins(this.allPlugins, this.eggPlugins);
@@ -336,17 +337,7 @@ module.exports = {
     return result.sequence.map(name => allPlugins[name]);
   },
 
-  // Get the real plugin path
-  getPluginPath(plugin) {
-    if (plugin.path) {
-      return plugin.path;
-    }
-
-    if (plugin.package) {
-      assert(isValidatePackageName(plugin.package), `plugin ${plugin.name} invalid, use 'path' instead of package: "${plugin.package}"`);
-    }
-
-    const name = plugin.package || plugin.name;
+  getLookupDirs() {
     const lookupDirs = new Set();
 
     // try to locate the plugin in the following directories's node_modules
@@ -362,17 +353,36 @@ module.exports = {
     // should find the $cwd when test the plugins under npm3
     lookupDirs.add(process.cwd());
 
+    return lookupDirs;
+  },
+
+  // Get the real plugin path
+  getPluginPath(plugin) {
+    if (plugin.path) {
+      return plugin.path;
+    }
+
+    if (plugin.package) {
+      assert(isValidatePackageName(plugin.package), `plugin ${plugin.name} invalid, use 'path' instead of package: "${plugin.package}"`);
+    }
+
+    return this._resolvePluginPath(plugin);
+  },
+
+  _resolvePluginPath(plugin) {
+    const name = plugin.package || plugin.name;
+
     try {
       // should find the plugin directory
       // pnpm will lift the node_modules to the sibling directory
       // 'node_modules/.pnpm/yadan@2.0.0/node_modules/yadan/node_modules',
       // 'node_modules/.pnpm/yadan@2.0.0/node_modules',  <- this is the sibling directory
       // 'node_modules/.pnpm/egg@2.33.1/node_modules/egg/node_modules',
       // 'node_modules/.pnpm/egg@2.33.1/node_modules', <- this is the sibling directory
-      const filePath = require.resolve(`${name}/package.json`, { paths: [ ...lookupDirs ] });
+      const filePath = require.resolve(`${name}/package.json`, { paths: [ ...this.lookupDirs ] });
       return path.dirname(filePath);
     } catch (_) {
-      throw new Error(`Can not find plugin ${name} in "${[ ...lookupDirs ].join(', ')}"`);
+      throw new Error(`Can not find plugin ${name} in "${[ ...this.lookupDirs ].join(', ')}"`);
     }
   },
 

test/loader/mixin/load_plugin.test.js

@@ -72,8 +72,8 @@ describe('test/load_plugin.test.js', function() {
     const loader = app.loader;
     const loaderOrders = [];
     [
-      'loadAppPlugins',
       'loadEggPlugins',
+      'loadAppPlugins',
       'loadCustomPlugins',
     ].forEach(method => {
       mm(loader, method, () => {
@@ -84,8 +84,8 @@ describe('test/load_plugin.test.js', function() {
 
     loader.loadPlugin();
     assert.deepEqual(loaderOrders, [
-      'loadAppPlugins',
       'loadEggPlugins',
+      'loadAppPlugins',
       'loadCustomPlugins',
     ]);
   });