[Refactor]: GRPC client setup (#483)

* added elixir tools to .gitiignore

* chore: start client supervisor in application

* doc: remove supervisor

* format

* chore: remove dead code

* Update grpc_client/lib/grpc/client/application.ex

Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>

* Update .gitignore

Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>

* Update grpc_client/lib/grpc/client/application.ex

Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>

* remove bench application.ex

* fix: remove client supervisor

* remove supervisor from tests

---------

Co-authored-by: Adriano Santos <adriano.santos@v3.com.br>
Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>

Author: 3 people

.gitignore

@@ -24,6 +24,5 @@ erl_crash.dump
 
 .elixir_ls
 
-.elixir_tools
 
 grpc-*.tar

benchmark/lib/benchmark/application.ex

@@ -15,7 +15,6 @@ defmodule Benchmark.MixProject do
   def application do
     [
       extra_applications: [:logger],
-      mod: {Benchmark.Application, []}
     ]
   end
 

benchmark/mix.exs

@@ -27,7 +27,6 @@ You can connect using `DNS`, `Unix Domain sockets`, and `IPv4/IPv6` for now.
 ### DNS
 
 ```elixir
-iex> {:ok, _pid} = GRPC.Client.Supervisor.start_link()
 iex> {:ok, channel} = GRPC.Stub.connect("dns://orders.prod.svc.cluster.local:50051")
 iex> request = Orders.GetOrderRequest.new(id: "123")
 iex> {:ok, reply} = channel |> Orders.OrderService.Stub.get_order(request)

grpc_client/guides/advanced/load_balancing.md

@@ -6,23 +6,7 @@ This section demonstrates how to establish client connections and perform RPC ca
 
 ## Basic Connection and RPC
 
-Typically, you start this client supervisor as part of your application's supervision tree:
-
-```elixir
-children = [
-  GRPC.Client.Supervisor
-]
-
-opts = [strategy: :one_for_one, name: MyApp.Supervisor]
-Supervisor.start_link(children, opts)
-``` 
-
-You can also start it manually in scripts or test environments:
-```elixir
-{:ok, _pid} = GRPC.Client.Supervisor.start_link()
-``` 
-
-Then connect with gRPC server:
+Connect with gRPC server:
 
 ```elixir
 iex> {:ok, channel} = GRPC.Stub.connect("localhost:50051")

grpc_client/guides/getting_started/client.md

@@ -0,0 +1,13 @@
+defmodule GRPC.Client.Application do
+  @moduledoc false
+  use Application
+
+  def start(_type, _args) do
+    children = [
+      {DynamicSupervisor, [name: GRPC.Client.Supervisor]}
+    ]
+
+    opts = [strategy: :one_for_one, name: GRPC.Supervisor]
+    Supervisor.start_link(children, opts)
+  end
+end

grpc_client/lib/grpc/client/application.ex

@@ -153,26 +153,6 @@ defmodule GRPC.Client.Connection do
   """
   @spec connect(String.t(), keyword()) :: {:ok, Channel.t()} | {:error, any()}
   def connect(target, opts \\ []) do
-    supervisor_pid = Process.whereis(GRPC.Client.Supervisor)
-
-    if is_nil(supervisor_pid) or !Process.alive?(supervisor_pid) do
-      raise """
-      GRPC.Client.Supervisor is not running. Please ensure it is started as part of your
-      application's supervision tree:
-
-          children = [
-            {GRPC.Client.Supervisor, []}
-          ]
-
-          opts = [strategy: :one_for_one, name: MyApp.Supervisor]
-          Supervisor.start_link(children, opts)
-
-      You can also start it manually in scripts or test environments:
-
-          {:ok, _pid} = DynamicSupervisor.start_link(strategy: :one_for_one, name: GRPC.Client.Supervisor)
-      """
-    end
-
     ref = make_ref()
 
     case build_initial_state(target, Keyword.merge(opts, ref: ref)) do
@@ -184,7 +164,6 @@ defmodule GRPC.Client.Connection do
             {:ok, ch}
 
           {:error, {:already_started, _pid}} ->
-            # race: someone else started it first, ask the running process for its current channel
             case pick_channel(opts) do
               {:ok, %Channel{} = channel} ->
                 {:ok, channel}

grpc_client/lib/grpc/client/connection.ex

@@ -22,6 +22,7 @@ defmodule GrpcClient.MixProject do
 
   def application do
     [
+      mod: {GRPC.Client.Application, []},
       extra_applications: [:logger]
     ]
   end