fix bug with dots in filename and add tests

Author: Gaurav0

app/adapters/gist-file.js

@@ -2,6 +2,7 @@ import ApplicationAdapter from './application';
 
 export default ApplicationAdapter.extend({
   generateIdForRecord(store, type, inputProperties) {
-    return inputProperties.filePath.replace(/\./gi, '\\.').replace(/\//gi, '.');
+    return inputProperties.fileName ||
+      inputProperties.filePath.replace(/\./gi, '\\.').replace(/\//gi, '.');
   }
 });

app/mixins/resize.js

@@ -5,15 +5,16 @@ import $ from 'jquery';
 export default Mixin.create({
   didInsertElement() {
     this._super();
-    $(window).on('resize', this.resizeHandler);
+    this.boundResizeHandler = this.resizeHandler.bind(this);
+    $(window).on('resize', this.boundResizeHandler);
   },
 
   willDestroyElement() {
     this._super();
-    $(window).off('resize', this.resizeHandler);
+    $(window).off('resize', this.boundResizeHandler);
   },
 
   resizeHandler() {
-    return run.bind(this, 'didResize');
+    return run.bind(() => this.didResize());
   }
 });

app/models/gist-file.js

@@ -15,25 +15,28 @@ export default DS.Model.extend({
    */
   filePath: computed('fileName', {
     get() {
-      var fileName = this.fileName || '';
+      let fileName = this.fileName || '';
+      let filePath = '';
 
       // If the file name has an escaped `.`, we're using the new version of path
       // encoding that supports multiple periods in a path.
       // If not, we assume the last period separates the file ending and the rest are `/`s.
       // Required for back compat.
       // Ref: https://github.com/ember-cli/ember-twiddle/issues/658
-      var hasEscapedPeriod = /\\\./.test(fileName);
+      let hasEscapedPeriod = /\\\./.test(fileName);
       if (hasEscapedPeriod) {
-        return fileName.replace(/[^\\]\./gi, '/').replace(/\\\./gi, '.');
+        filePath = fileName.replace(/([^\\])\./gi, "$1/").replace(/\\\./gi, '.');
       }
       else {
-        var parts = fileName.split('.');
-        return parts.slice(0, -1).join('/') + '.' + parts.slice(-1);
+        let parts = fileName.split('.');
+        filePath = parts.slice(0, -1).join('/') + '.' + parts.slice(-1);
       }
+      return filePath;
     },
 
     set(key, value) {
-      this.set('fileName', value.replace(/\./gi, '\\.').replace(/\//gi, '.'));
+      let fileName = value.replace(/\./gi, '\\.').replace(/\//gi, '.');
+      this.set('fileName', fileName);
       return value;
     }
   }),

app/services/ember-cli.js

@@ -194,9 +194,11 @@ export default Service.extend({
     // Remove app prefix if present
     let name = filePath.replace(/^app\//, '');
 
-    return Path.join(twiddleAppName,
+    let moduleName = Path.join(twiddleAppName,
       Path.relative('.', Path.dirname(name)),
       Path.basename(name, Path.extname(name)));
+
+    return moduleName;
   },
 
   /**

app/utils/push-deletion.js

@@ -40,5 +40,9 @@ export function pushDeletion(store, type, id) {
 
 export function pushDeleteAll(store, type) {
   let records = store.peekAll(type);
-  records.forEach(record => pushDeletion(store, type, record.get('id')));
+  records.forEach(record => {
+    if (record.get('id')) {
+      pushDeletion(store, type, record.get('id'));
+    }
+  });
 }

tests/unit/models/gist-file-test.js

@@ -36,4 +36,20 @@ module('Unit | Model | gist file', function(hooks) {
       await run(() => model.deleteRecord());
     });
   });
+
+  test('correctly determines filePath from fileName', function(assert) {
+    const store = this.owner.lookup('service:store');
+    let file1 = store.createRecord('gist-file', {
+      fileName: 'twiddle\\.json'
+    });
+    assert.equal(file1.filePath, 'twiddle.json');
+    let file2 = store.createRecord('gist-file', {
+      fileName: 'controllers.application\\.js'
+    });
+    assert.equal(file2.filePath, 'controllers/application.js');
+    let file3 = store.createRecord('gist-file', {
+      fileName: 'controllers.app\\.ication\\.js'
+    });
+    assert.equal(file3.filePath, 'controllers/app.ication.js');
+  });
 });