Merge pull request #209 from tuxmea/lint_plugins

enable lint plugins

Author: sebastiansucker

Gemfile

@@ -35,3 +35,74 @@ if puppetversion = ENV['PUPPET_GEM_VERSION']
 else
   gem 'puppet', '< 4', :require => false
 end
+
+# puppet lint plugins
+# https://puppet.community/plugins/#puppet-lint
+gem 'puppet-lint-appends-check',
+    :git => 'https://github.com/puppet-community/puppet-lint-appends-check.git',
+    :require => false
+gem 'puppet-lint-classes_and_types_beginning_with_digits--check',
+    :git => 'https://github.com/puppet-community/puppet-lint-classes_and_types_beginning_with_digits-check.git',
+    :require => false
+gem 'puppet-lint-empty_string-check',
+    :git => 'https://github.com/puppet-community/puppet-lint-empty_string-check.git',
+    :require => false
+gem 'puppet-lint-file_ensure-check',
+    :git => 'https://github.com/puppet-community/puppet-lint-file_ensure-check.git',
+    :require => false
+gem 'puppet-lint-leading_zero-check',
+    :git => 'https://github.com/puppet-community/puppet-lint-leading_zero-check.git',
+    :require => false
+gem 'puppet-lint-numericvariable',
+    :git => 'https://github.com/fiddyspence/puppetlint-numericvariable.git',
+    :require => false
+gem 'puppet-lint-resource_reference_syntax',
+    :git => 'https://github.com/tuxmea/puppet-lint-resource_reference_syntax.git',
+    :require => false
+gem 'puppet-lint-security-plugins',
+    :git => 'https://github.com/floek/puppet-lint-security-plugins.git',
+    :require => false
+gem 'puppet-lint-spaceship_operator_without_tag-check',
+    :git => 'https://github.com/puppet-community/puppet-lint-spaceship_operator_without_tag-check.git',
+    :require => false
+gem 'puppet-lint-strict_indent-check',
+    :git => 'https://github.com/relud/puppet-lint-strict_indent-check.git',
+    :require => false
+gem 'puppet-lint-trailing_comma-check',
+    :git => 'https://github.com/puppet-community/puppet-lint-trailing_comma-check.git',
+    :require => false
+gem 'puppet-lint-trailing_newline-check',
+    :git => 'https://github.com/rodjek/puppet-lint-trailing_newline-check.git',
+    :require => false
+gem 'puppet-lint-undef_in_function-check',
+    :git => 'https://github.com/puppet-community/puppet-lint-undef_in_function-check.git',
+    :require => false
+gem 'puppet-lint-unquoted_string-check',
+    :git => 'https://github.com/puppet-community/puppet-lint-unquoted_string-check.git',
+    :require => false
+gem 'puppet-lint-usascii_format-check',
+    :git => 'https://github.com/jpmasters/puppet-lint-usascii_format-check.git',
+    :require => false
+gem 'puppet-lint-variable_contains_upcase',
+    :git => 'https://github.com/fiddyspence/puppetlint-variablecase.git',
+    :require => false
+gem 'puppet-lint-version_comparison-check',
+    :git => 'https://github.com/puppet-community/puppet-lint-version_comparison-check.git',
+    :require => false
+
+# disabled lint plugins
+#gem 'puppet-lint-file_source_rights-check',
+#    :git => 'https://github.com/camptocamp/puppet-lint-file_source_rights-check.git',
+#    :require => false
+#gem 'puppet-lint-fileserver-check',
+#    :git => 'https://github.com/camptocamp/puppet-lint-fileserver-check.git',
+#    :require => false
+#gem 'puppet-lint-global_resource-check',
+#    :git => 'https://github.com/ninech/puppet-lint-global_resource-check.git',
+#    :require => false
+#gem 'puppet-lint-package_ensure-check',
+#    :git => 'https://github.com/danzilio/puppet-lint-package_ensure-check.git',
+#    :require => false
+#gem 'puppet-lint-param-docs',
+#    :git => 'https://github.com/domcleal/puppet-lint-param-docs.git',
+#    :require => false

Rakefile

@@ -27,7 +27,7 @@ PuppetLint::RakeTask.new(:lint) do |config|
   #config.ignore_paths = ['vendor/**/*.pp']
 
   # List of checks to disable
-  config.disable_checks = ['80chars']
+  config.disable_checks = ['80chars', 'class_inherits_from_params_class']
 
   # Should the task fail if there were any warnings, defaults to false
   #config.fail_on_warnings = true

manifests/compute_node/config.pp

@@ -37,20 +37,31 @@
   validate_string ($debian_mirror_url)
   validate_hash   ($preseed_data)
 
+  $_polkit_file_path = $::osfamily ? {
+    'RedHat' => '/etc/polkit-1/localauthority/50-local.d/50-org.libvirt.unix.manage-opennebula.pkla',
+    'Debian' => '/var/lib/polkit-1/localauthority/50-local.d/50-org.libvirt.unix.manage-opennebula.pkla',
+  }
+
   file { '/etc/libvirt/libvirtd.conf':
     ensure => file,
     source => 'puppet:///modules/one/libvirtd.conf',
+    owner  => 'root',
+    group  => 'root',
     notify => Service[$libvirtd_srv],
   } ->
 
   file { $libvirtd_cfg:
     ensure => file,
     source => $libvirtd_source,
+    owner  => 'root',
+    group  => 'root',
     notify => Service[$libvirtd_srv],
   } ->
 
   file { '/etc/udev/rules.d/80-kvm.rules':
     ensure => file,
+    owner  => 'root',
+    group  => 'root',
     source => 'puppet:///modules/one/udev-kvm-rules',
   } ->
 
@@ -72,16 +83,17 @@
 
   file { 'polkit-opennebula':
     ensure => file,
-    path   => $::osfamily ? {
-      'RedHat' => '/etc/polkit-1/localauthority/50-local.d/50-org.libvirt.unix.manage-opennebula.pkla',
-      'Debian' => '/var/lib/polkit-1/localauthority/50-local.d/50-org.libvirt.unix.manage-opennebula.pkla',
-    },
+    path   => $_polkit_file_path,
+    owner  => 'root',
+    group  => 'root',
     source => 'puppet:///modules/one/50-org.libvirt.unix.manage-opennebula.pkla',
   } ->
 
   file { '/etc/libvirt/qemu.conf':
     ensure => file,
-    source => 'puppet:///modules/one/qemu.conf'
+    owner  => 'root',
+    group  => 'root',
+    source => 'puppet:///modules/one/qemu.conf',
   } ->
 
   file { '/var/lib/one/.virtinst':
@@ -105,8 +117,7 @@
     mode   => '0771',
   } ->
 
-  file { ['/var/lib/one/etc/kickstart.d',
-    '/var/lib/one/etc/preseed.d']:
+  file { ['/var/lib/one/etc/kickstart.d', '/var/lib/one/etc/preseed.d']:
     ensure  => directory,
     owner   => 'oneadmin',
     group   => 'oneadmin',
@@ -128,6 +139,8 @@
     file { '/sbin/brctl':
       ensure => link,
       target => '/usr/sbin/brctl',
+      owner  => 'root',
+      group  => 'root',
     }
   }
 

manifests/compute_node/install.pp

@@ -21,6 +21,6 @@
   $node_packages = $one::node_packages
 ) {
   package { $node_packages:
-      ensure => latest,
+    ensure => latest,
   }
 }

manifests/compute_node/service.pp

@@ -25,20 +25,20 @@
     enable    => true,
   }
   case $::osfamily {
-      'RedHat': {
-          service { 'ksmtuned':
-            ensure    => stopped,
-            enable    => false,
-            hasstatus => true,
-          }
-          service { 'ksm':
-            ensure    => running,
-            enable    => true,
-            hasstatus => true,
-          }
+    'RedHat': {
+      service { 'ksmtuned':
+        ensure    => stopped,
+        enable    => false,
+        hasstatus => true,
       }
-      default: {
-          notice('we need to check how to enable ksm.')
+      service { 'ksm':
+        ensure    => running,
+        enable    => true,
+        hasstatus => true,
       }
+    }
+    default: {
+      notice('we need to check how to enable ksm.')
+    }
   }
 }