add more specs, parameter documentation, validation

* added specs that test that the param works
* added parameter validation and specs for that
* added the docstring for the new parameter

Author: Felix Gilcher

manifests/init.pp

@@ -94,6 +94,9 @@
 #
 # ==== OpenNebula configuration parameters
 #
+# $oned_log_system - default 'file'
+#   the log subsystem to use, valid values are [file, syslog] 
+#
 # ===== OpenNebula Database configuration
 #
 # $oned_db - default oned
@@ -499,6 +502,12 @@
     }
   }
 
+  # I'd use member() here but the stdlib version we're currently using doesn't know that,
+  # so feel free to change once the stlib was updated to a more recent version
+  if (($oned_log_system != 'file') and ($oned_log_system != 'syslog')) {
+    fail("\"${oned_log_system}\" is not a valid logging subsystem. Valid values are [\"file\", \"syslog\"].")
+  }
+
   # check if version greater than or equal to 4.14 (used in templates)
   if ( versioncmp($one_version, '4.14') >= 0 ) {
     $version_gte_4_14 = true

spec/classes/opennebula_spec.rb

@@ -136,7 +136,22 @@
             it { should contain_file("#{onehome}/.ssh/id_dsa.pub").with_content(sshpubkey) }
             it { should contain_file("#{onehome}/.ssh/authorized_keys").with_content(sshpubkey) }
             it { should contain_file(oned_config).with_content(/^LOG = \[\n\s+system\s+=\s+"file"/m) }
-
+            context 'with syslog logging' do
+              let(:params) { {
+                  :oned            => true,
+                  :oned_log_system => 'syslog'
+              } }
+              it { should contain_file(oned_config).with_content(/^LOG = \[\n\s+system\s+=\s+"syslog"/m) }
+            end
+            context 'with invalid logging subsystem' do
+              let(:params) { {
+                  :oned            => true,
+                  :oned_log_system => 'invalid'
+              } }
+              it do
+                is_expected.to compile.and_raise_error(/"invalid" is not a valid logging subsystem. Valid values are \["file", "syslog"\]/)
+              end
+            end
             context 'with sqlite backend' do
               it { should contain_file(oned_config).with_content(/^DB = \[ backend = \"sqlite\"/) }
             end