removing try/except logic from bulk_upsert_mappings to faciltiate better logging

Author: fsecada01

sqlmodel_crud_utils/a_sync.py

@@ -307,24 +307,16 @@ async def bulk_upsert_mappings(
 ):
     if not pk_fields:
         pk_fields = ["id"]
-    try:
-        stmnt = upsert(model).values(payload)
-        stmnt = stmnt.on_conflict_do_update(
-            index_elements=[getattr(model, x) for x in pk_fields],
-            set_={k: getattr(stmnt.excluded, k) for k in payload[0].keys()},
-        )
-        results = await session_inst.execute(stmnt)
-
-        await session_inst.commit()
+    stmnt = upsert(model).values(payload)
+    stmnt = stmnt.on_conflict_do_update(
+        index_elements=[getattr(model, x) for x in pk_fields],
+        set_={k: getattr(stmnt.excluded, k) for k in payload[0].keys()},
+    )
+    results = await session_inst.execute(stmnt)
 
-        return True, results.all()
+    await session_inst.commit()
 
-    except Exception as e:
-        logger.error(
-            f"Failed to upsert values to DB. Please see error: "
-            f"{type(e), e, e.args}"
-        )
-        return False, []
+    return True, results.all()
 
 
 @logger.catch

sqlmodel_crud_utils/sync.py

@@ -304,24 +304,16 @@ def bulk_upsert_mappings(
 ):
     if not pk_fields:
         pk_fields = ["id"]
-    try:
-        stmnt = upsert(model).values(payload)
-        stmnt = stmnt.on_conflict_do_update(
-            index_elements=[getattr(model, x) for x in pk_fields],
-            set_={k: getattr(stmnt.excluded, k) for k in payload[0].keys()},
-        )
-        results = session_inst.execute(stmnt)
-
-        session_inst.commit()
+    stmnt = upsert(model).values(payload)
+    stmnt = stmnt.on_conflict_do_update(
+        index_elements=[getattr(model, x) for x in pk_fields],
+        set_={k: getattr(stmnt.excluded, k) for k in payload[0].keys()},
+    )
+    results = session_inst.execute(stmnt)
 
-        return True, results.all()
+    session_inst.commit()
 
-    except Exception as e:
-        logger.error(
-            f"Failed to upsert values to DB. Please see error: "
-            f"{type(e), e, e.args}"
-        )
-        return False, []
+    return True, results.all()
 
 
 @logger.catch