Commit 086a577
committed
Remove @logger.catch decorators and make loguru an optional dependency
@logger.catch silently swallows exceptions and returns None, preventing
proper error propagation to callers. This is unsuitable for production
where frameworks need exceptions to flow for proper HTTP responses,
retries, and observability. The existing try/except blocks already
provide targeted error handling with session rollback and explicit
logger.error() calls where needed.
Loguru is now an optional dependency (pip install sqlmodel_crud_utils[loguru])
so teams using their own logging/telemetry can use stdlib logging instead.
The logger in utils.py falls back to logging.getLogger() when loguru is
not installed.
https://claude.ai/code/session_01G7xKgBPQia81rZHBU6BxCG1 parent a103531 commit 086a577
4 files changed
Lines changed: 21 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
75 | 74 | | |
76 | 75 | | |
77 | 76 | | |
78 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
79 | 81 | | |
80 | 82 | | |
81 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
14 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
18 | 22 | | |
19 | 23 | | |
20 | 24 | | |
21 | | - | |
22 | 25 | | |
23 | 26 | | |
24 | 27 | | |
| |||
40 | 43 | | |
41 | 44 | | |
42 | 45 | | |
43 | | - | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
90 | 92 | | |
91 | 93 | | |
92 | 94 | | |
93 | | - | |
94 | 95 | | |
95 | 96 | | |
96 | 97 | | |
| |||
115 | 116 | | |
116 | 117 | | |
117 | 118 | | |
118 | | - | |
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| |||
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
160 | | - | |
161 | 160 | | |
162 | 161 | | |
163 | 162 | | |
| |||
204 | 203 | | |
205 | 204 | | |
206 | 205 | | |
207 | | - | |
208 | 206 | | |
209 | 207 | | |
210 | 208 | | |
| |||
417 | 415 | | |
418 | 416 | | |
419 | 417 | | |
420 | | - | |
421 | 418 | | |
422 | 419 | | |
423 | 420 | | |
| |||
443 | 440 | | |
444 | 441 | | |
445 | 442 | | |
446 | | - | |
447 | 443 | | |
448 | 444 | | |
449 | 445 | | |
| |||
481 | 477 | | |
482 | 478 | | |
483 | 479 | | |
484 | | - | |
485 | 480 | | |
486 | 481 | | |
487 | 482 | | |
| |||
514 | 509 | | |
515 | 510 | | |
516 | 511 | | |
517 | | - | |
518 | 512 | | |
519 | 513 | | |
520 | 514 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
13 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
14 | 18 | | |
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
18 | 22 | | |
19 | 23 | | |
20 | | - | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| |||
39 | 42 | | |
40 | 43 | | |
41 | 44 | | |
42 | | - | |
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
| |||
89 | 91 | | |
90 | 92 | | |
91 | 93 | | |
92 | | - | |
93 | 94 | | |
94 | 95 | | |
95 | 96 | | |
| |||
114 | 115 | | |
115 | 116 | | |
116 | 117 | | |
117 | | - | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
158 | 157 | | |
159 | 158 | | |
160 | 159 | | |
| |||
201 | 200 | | |
202 | 201 | | |
203 | 202 | | |
204 | | - | |
205 | 203 | | |
206 | 204 | | |
207 | 205 | | |
| |||
414 | 412 | | |
415 | 413 | | |
416 | 414 | | |
417 | | - | |
418 | 415 | | |
419 | 416 | | |
420 | 417 | | |
| |||
444 | 441 | | |
445 | 442 | | |
446 | 443 | | |
447 | | - | |
448 | 444 | | |
449 | 445 | | |
450 | 446 | | |
| |||
482 | 478 | | |
483 | 479 | | |
484 | 480 | | |
485 | | - | |
486 | 481 | | |
487 | 482 | | |
488 | 483 | | |
| |||
515 | 510 | | |
516 | 511 | | |
517 | 512 | | |
518 | | - | |
519 | 513 | | |
520 | 514 | | |
521 | 515 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
6 | 12 | | |
7 | 13 | | |
8 | 14 | | |
| |||
0 commit comments