Skip to content

Commit 73fbe67

Browse files
committed
handle PR feedback
1 parent aedadce commit 73fbe67

3 files changed

Lines changed: 5 additions & 8 deletions

File tree

RELEASE_NOTES.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
### 3.1.1 - 2026-04-03
2-
* Fixed GraphQL client provider handling for schema types that reuse reserved scalar names such as `Date`, so introspection kind now takes precedence over built-in scalar mappings.
3-
41
#### 0.0.1-beta - 2016-04-19
52
* Initial release
63

@@ -243,6 +240,9 @@
243240
* Changed `GraphQLOptionsDefaults.WebSocketConnectionInitTimeoutInMs` const type to `double`
244241
* Improved Relay XML documentation comments
245242

246-
### 3.1.1 - Unreleased
243+
### 3.1.1 - 2026-04-03
244+
245+
* Fixed GraphQL client provider handling for schema types that reuse reserved scalar names such as `Date`, so introspection kind now takes precedence over built-in scalar mappings.
247246

247+
### 3.1.2 - Unreleased
248248
* Fixed planning phase crash when inline fragments reference types not included in union or interface definitions

src/FSharp.Data.GraphQL.Client.DesignTime/ProvidedTypesHelper.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ module internal ProvidedOperation =
309309
| Some t -> struct (variableName,typeName, TypeMapping.makeOption t)
310310
| None when TypeMapping.isScalarTypeName schemaTypes typeName -> struct (variableName, typeName, typeof<string option>)
311311
| None ->
312-
match schemaProvidedTypes.TryFind(typeName) with
312+
match schemaProvidedTypes.TryFind typeName with
313313
| Some t -> struct (variableName, typeName, TypeMapping.makeOption t)
314314
| None -> failwith $"""Unable to find variable type "%s{typeName}" in the schema definition."""
315315
| ListType itype ->

tests/FSharp.Data.GraphQL.IntegrationTests/ReservedScalarNameProviderTests.fs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
module FSharp.Data.GraphQL.IntegrationTests.ReservedScalarNameProviderTests
22

33
open Xunit
4-
open Helpers
54
open FSharp.Data.GraphQL
65

76
type ObjectDateProvider = GraphQLProvider<"reserved_scalar_object_date_introspection.json">
@@ -42,9 +41,7 @@ module InputDateSchema =
4241
[<Fact>]
4342
let ``Should allow object types that reuse reserved scalar names`` () =
4443
ObjectDateSchema.compileSmoke ()
45-
true |> equals true
4644

4745
[<Fact>]
4846
let ``Should allow input object types that reuse reserved scalar names`` () =
4947
InputDateSchema.compileSmoke ()
50-
true |> equals true

0 commit comments

Comments
 (0)