Skip to content

fix: react loop is missing a check for result without tool calls #762

@markstur

Description

@markstur

I'm seeing the react_using_mellea test with DuckDuckGo and Ollama intermittently loop and run out of iterations.
When this happens there is often already a step.value that has the answer. More iterations doesn't solve anything and
is_final is never called.

I suspect this could have something to do with DDGS rate limiting but have no evidence.

Since there is a whole in the logic, it seem the step value should be used when possible. TBD whether it should be used ASAP or maybe just checked after all iterations are used up.

I have a fix that works pretty good for me, but need help determining if the fix would have any bad side effects in other cases.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions