Skip to content

Commit e65deb6

Browse files
authored
Merge pull request #40 from gisce/autofix/wrapped2_to3_fix
Fix "Prefer `format()` over string interpolation operator" issue
2 parents 57f7b4e + 3ea049f commit e65deb6

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

libcomxml/core/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def set_value(self, value):
6666

6767

6868
def __str__(self):
69-
return (u"<Field:%s>" % (self.name,)).encode('utf8')
69+
return (u"<Field:{0!s}>".format(self.name)).encode('utf8')
7070

7171
def __unicode__(self):
7272
return unicode(self.__str__(), 'utf8')
@@ -117,7 +117,7 @@ def _parse_value(self, element, value=None):
117117
elif isinstance(value, list):
118118
self._parse_list(element, value)
119119
else: # default: cast to unicode
120-
element.text = u"%s" % value
120+
element.text = u"{0!s}".format(value)
121121

122122
return element
123123

@@ -127,7 +127,7 @@ def element(self, parent=None):
127127
:param parent: an etree Element to be used as parent for this one
128128
"""
129129
if self.namespace:
130-
name = '{%s}%s' % (self.namespace, self.name)
130+
name = '{{{0!s}}}{1!s}'.format(self.namespace, self.name)
131131
else:
132132
name = self.name
133133
if parent is not None:
@@ -202,7 +202,7 @@ def feed(self, vals):
202202

203203

204204
def __str__(self):
205-
return (u"<Model:%s>" % (self.name,)).encode('utf8')
205+
return (u"<Model:{0!s}>".format(self.name)).encode('utf8')
206206

207207
def __unicode__(self):
208208
return unicode(self.__str__(), 'utf8')

tests/test_libcomxml.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def test_value_rep(self):
7676
grouping=True)
7777
self.assertEqual(formated, self.field.element().text)
7878
self.assertEqual(str(self.field),
79-
'<Quantity uom="unit">%s</Quantity>' % formated)
79+
'<Quantity uom="unit">{0!s}</Quantity>'.format(formated))
8080

8181
def test_update_attributes(self):
8282
self.field.attributes.update({'uom': 'kg'})

0 commit comments

Comments
 (0)