Skip to content

Commit 1e95fa9

Browse files
basiclinesCopilot
andcommitted
Fix PR review comments: spec inconsistencies
1. TextTitle/TextHeading previews: text → children (matches component API) 2. SelectAutocomplete: add iconPrompt to tokens and dependencies table 3. Rust target: rustc 1.75 → 1.85 (2024 edition requires 1.85+) 4. colors.preview: remove nonexistent tokens (textMuted, textDisabled, textOnBackground) 5. PR description: updated to reflect 4 targets and OpenTUI + React for bun Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 77ec4db commit 1e95fa9

5 files changed

Lines changed: 8 additions & 7 deletions

File tree

components/SelectAutocomplete/SelectAutocomplete.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ category: input
77

88
tokens:
99
colors: [selected, statusSuccess, textSecondary, textTertiary]
10-
icons: [iconSuccess]
10+
icons: [iconSuccess, iconPrompt]
1111

1212
types:
1313
SelectAutocompleteItem:
@@ -356,4 +356,5 @@ due to search input.
356356
| `textSecondary` | color | Escape item suffix and no-results message | No |
357357
| `textTertiary` | color | Search placeholder text | No |
358358
| `iconSuccess` | icon | Current item marker glyph (✓) | No |
359+
| `iconPrompt` | icon | Highlighted item indicator (❯) | Yes |
359360
| `HintBar` | component | Footer keyboard navigation hints | No |

components/TextHeading/TextHeading.preview.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ version: 1
77
## Default
88

99
```props
10-
text: "Section Heading"
10+
children: "Section Heading"
1111
```
1212

1313
## Error
1414

1515
```props
16-
text: "Error Details"
16+
children: "Error Details"
1717
type: error
1818
```

components/TextTitle/TextTitle.preview.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ version: 1
77
## Default
88

99
```props
10-
text: "Welcome to TUIkit"
10+
children: "Welcome to TUIkit"
1111
```
1212

1313
## Error
1414

1515
```props
16-
text: "Something went wrong"
16+
children: "Something went wrong"
1717
type: error
1818
```

targets/rust.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
kind: target
33
name: rust
44
language: Rust
5-
runtime: rustc 1.75+ (2024 edition)
5+
runtime: rustc 1.85+ (2024 edition)
66
framework:
77
name: Ratatui
88
version: ">=0.28"

tokens/colors.preview.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ groups: [text, background, status, brand, ui, diff, markdown]
1313
## Text tokens
1414

1515
```props
16-
tokens: [textPrimary, textSecondary, textMuted, textDisabled, textOnBackground, textOnBackgroundSecondary]
16+
tokens: [textPrimary, textSecondary, textTertiary, textOnBackgroundSecondary]
1717
```
1818

1919
## Status tokens

0 commit comments

Comments
 (0)