Skip to content

Commit a5ef036

Browse files
committed
Note that common standard library types can be vulnerable to gadget-chain attacks
1 parent 93e05db commit a5ef036

5 files changed

Lines changed: 15 additions & 5 deletions

File tree

csharp/ql/src/Security Features/CWE-502/UnsafeDeserialization.qhelp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ arbitrary classes. Serialization frameworks that use a schema to instantiate
1313
only expected, predefined types are generally not tracked by this query. Such
1414
frameworks are generally safe with respect to arbitrary-class-instantiation and
1515
gadget-chain attacks when the schema is trusted and does not permit
16-
user-controlled type resolution.
16+
user-controlled type resolution. However, care must be taken to ensure the schema
17+
strictly limits the allowed types. Permitting common standard library classes
18+
can still leave the application vulnerable to gadget-chain attacks.
1719
</p>
1820

1921
</overview>

csharp/ql/src/Security Features/CWE-502/UnsafeDeserializationUntrustedInput.qhelp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ arbitrary classes. Serialization frameworks that use a schema to instantiate
1313
only expected, predefined types are generally not tracked by this query. Such
1414
frameworks are generally safe with respect to arbitrary-class-instantiation and
1515
gadget-chain attacks when the schema is trusted and does not permit
16-
user-controlled type resolution.
16+
user-controlled type resolution. However, care must be taken to ensure the schema
17+
strictly limits the allowed types. Permitting common standard library classes
18+
can still leave the application vulnerable to gadget-chain attacks.
1719
</p>
1820

1921
</overview>

java/ql/src/Security/CWE/CWE-502/UnsafeDeserialization.qhelp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@ only expected, predefined types are generally not tracked by this query. For
2525
example, Apache Avro's deserialization methods follow a schema and are
2626
therefore generally safe with respect to arbitrary-class-instantiation and
2727
gadget-chain attacks when the schema is trusted and does not permit
28-
user-controlled type resolution.
28+
user-controlled type resolution. However, care must be taken to ensure the schema
29+
strictly limits the allowed types. Permitting common standard library classes
30+
can still leave the application vulnerable to gadget-chain attacks.
2931
</p>
3032
</overview>
3133

python/ql/src/Security/CWE-502/UnsafeDeserialization.qhelp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ arbitrary classes. Serialization frameworks that use a schema to instantiate
2222
only expected, predefined types are generally not tracked by this query. Such
2323
frameworks are generally safe with respect to arbitrary-class-instantiation and
2424
gadget-chain attacks when the schema is trusted and does not permit
25-
user-controlled type resolution.
25+
user-controlled type resolution. However, care must be taken to ensure the schema
26+
strictly limits the allowed types. Permitting common standard library classes
27+
can still leave the application vulnerable to gadget-chain attacks.
2628
</p>
2729
</overview>
2830

ruby/ql/src/queries/security/cwe-502/UnsafeDeserialization.qhelp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ arbitrary classes or objects. Serialization frameworks that use a schema to inst
1313
only expected, predefined types are generally not tracked by this query. Such
1414
frameworks are generally safe with respect to arbitrary-class-instantiation and
1515
gadget-chain attacks when the schema is trusted and does not permit
16-
user-controlled type resolution.
16+
user-controlled type resolution. However, care must be taken to ensure the schema
17+
strictly limits the allowed types. Permitting common standard library classes
18+
can still leave the application vulnerable to gadget-chain attacks.
1719
</p>
1820
</overview>
1921

0 commit comments

Comments
 (0)