Free versions in rb_version_compare

philipturnbull · philipturnbull · commit bf6866c9f9d7 · 2018-02-05T13:56:37.000-05:00
diff --git a/ext/version_sorter/version_sorter.c b/ext/version_sorter/version_sorter.c
@@ -239,7 +239,13 @@ rb_version_compare(VALUE rb_self, VALUE rb_version_a, VALUE rb_version_b)
 {
 	struct version_number *version_a = parse_version_number(StringValueCStr(rb_version_a));
 	struct version_number *version_b = parse_version_number(StringValueCStr(rb_version_b));
-	return INT2NUM(version_compare_cb(&version_a, &version_b));
+
+	VALUE result = INT2NUM(version_compare_cb(&version_a, &version_b));
+
+	xfree(version_a);
+	xfree(version_b);
+
+	return result;
 }
 
 void Init_version_sorter(void)

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,13 @@ rb_version_compare(VALUE rb_self, VALUE rb_version_a, VALUE rb_version_b)`
`239`	`239`	`{`
`240`	`240`	`struct version_number *version_a = parse_version_number(StringValueCStr(rb_version_a));`
`241`	`241`	`struct version_number *version_b = parse_version_number(StringValueCStr(rb_version_b));`
`242`		`- return INT2NUM(version_compare_cb(&version_a, &version_b));`
	`242`	`+`
	`243`	`+ VALUE result = INT2NUM(version_compare_cb(&version_a, &version_b));`
	`244`	`+`
	`245`	`+ xfree(version_a);`
	`246`	`+ xfree(version_b);`
	`247`	`+`
	`248`	`+ return result;`
`243`	`249`	`}`
`244`	`250`
`245`	`251`	`void Init_version_sorter(void)`