Skip to content

Commit b6aee6a

Browse files
authored
Fix error on missing package (#31)
Fixes #30
1 parent 71a860b commit b6aee6a

3 files changed

Lines changed: 5 additions & 9 deletions

File tree

src/lib/service.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ const makeAllRelative = p => R.when(R.has(p), R.over(R.lensProp(p), R.map(makeRe
66
const makePackageRelative = R.compose(makeAllRelative('include'), makeAllRelative('exclude'));
77

88
const setPackage = R.pipe(
9+
R.defaultTo({}),
910
makePackageRelative,
1011
R.over(R.lensProp('exclude'), R.append('**')),
1112
R.assoc('individually', true)
@@ -15,7 +16,7 @@ const fnPath = R.compose(R.replace(/\.[^.]+$/, '.js'), R.prop('handler'));
1516

1617
const setFnsPackage = R.map(
1718
R.pipe(
18-
R.over(R.lensProp('package'), makePackageRelative),
19+
R.when(R.has('package'), R.over(R.lensProp('package'), makePackageRelative)),
1920
R.converge(
2021
R.over(R.lensPath(['package', 'include'])),
2122
[R.compose(R.append, fnPath), R.identity]

test/fns.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ const originalFns = {
88
},
99
secondGet: {
1010
handler: 'functions/second/get.handler',
11-
package: {
12-
include: ['node_modules/**'],
13-
exclude: ['abc.js'],
14-
},
1511
},
1612
post: {
1713
handler: 'functions/post.handler',

test/service.test.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ const path = require('path');
22
const service = require('../src/lib/service');
33
const fns = require('./fns.js');
44

5-
test('service package when no package', () => {
5+
test('service package when package is undefined', () => {
66
const expectedPackage = {
77
individually: true,
88
exclude: ['**'],
99
};
10-
expect(service.setPackage({})).toEqual(expectedPackage);
10+
expect(service.setPackage(undefined)).toEqual(expectedPackage);
1111
});
1212

1313
test('service package with existing package and no include/exclude', () => {
@@ -51,8 +51,7 @@ test('setFnsPackage', () => {
5151
secondGet: {
5252
handler: 'functions/second/get.handler',
5353
package: {
54-
include: ['../node_modules/**', 'functions/second/get.js'],
55-
exclude: ['../abc.js'],
54+
include: ['functions/second/get.js'],
5655
},
5756
},
5857
post: {

0 commit comments

Comments
 (0)