fix: better support for fallback mode (#683)

gcf-owl-bot[bot] · web-flow · commit f97d4ec5197c · 2022-08-23T00:04:20.000Z
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: https://github.com/googleapis/googleapis-gen/commit/cb6f37aeff2a3472e40a7bbace8c67d75e24bee5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
diff --git a/samples/generated/v1/language_service.analyze_entities.js b/samples/generated/v1/language_service.analyze_entities.js
@@ -23,6 +23,9 @@
 function main(document) {
   // [START language_v1_generated_LanguageService_AnalyzeEntities_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/language_service.analyze_entity_sentiment.js b/samples/generated/v1/language_service.analyze_entity_sentiment.js
@@ -23,6 +23,9 @@
 function main(document) {
   // [START language_v1_generated_LanguageService_AnalyzeEntitySentiment_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/language_service.analyze_sentiment.js b/samples/generated/v1/language_service.analyze_sentiment.js
@@ -23,6 +23,9 @@
 function main(document) {
   // [START language_v1_generated_LanguageService_AnalyzeSentiment_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/language_service.analyze_syntax.js b/samples/generated/v1/language_service.analyze_syntax.js
@@ -23,6 +23,9 @@
 function main(document) {
   // [START language_v1_generated_LanguageService_AnalyzeSyntax_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/language_service.annotate_text.js b/samples/generated/v1/language_service.annotate_text.js
@@ -23,6 +23,9 @@
 function main(document, features) {
   // [START language_v1_generated_LanguageService_AnnotateText_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/language_service.classify_text.js b/samples/generated/v1/language_service.classify_text.js
@@ -23,6 +23,9 @@
 function main(document) {
   // [START language_v1_generated_LanguageService_ClassifyText_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/snippet_metadata.google.cloud.language.v1.json b/samples/generated/v1/snippet_metadata.google.cloud.language.v1.json
@@ -22,7 +22,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 54,
+                    "end": 57,
                     "type": "FULL"
                 }
             ],
@@ -66,7 +66,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 54,
+                    "end": 57,
                     "type": "FULL"
                 }
             ],
@@ -110,7 +110,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 54,
+                    "end": 57,
                     "type": "FULL"
                 }
             ],
@@ -154,7 +154,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 54,
+                    "end": 57,
                     "type": "FULL"
                 }
             ],
@@ -198,7 +198,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 50,
+                    "end": 53,
                     "type": "FULL"
                 }
             ],
@@ -238,7 +238,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 59,
+                    "end": 62,
                     "type": "FULL"
                 }
             ],
diff --git a/samples/generated/v1beta2/language_service.analyze_entities.js b/samples/generated/v1beta2/language_service.analyze_entities.js
@@ -23,6 +23,9 @@
 function main(document) {
   // [START language_v1beta2_generated_LanguageService_AnalyzeEntities_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta2/language_service.analyze_entity_sentiment.js b/samples/generated/v1beta2/language_service.analyze_entity_sentiment.js
@@ -23,6 +23,9 @@
 function main(document) {
   // [START language_v1beta2_generated_LanguageService_AnalyzeEntitySentiment_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta2/language_service.analyze_sentiment.js b/samples/generated/v1beta2/language_service.analyze_sentiment.js
@@ -23,6 +23,9 @@
 function main(document) {
   // [START language_v1beta2_generated_LanguageService_AnalyzeSentiment_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta2/language_service.analyze_syntax.js b/samples/generated/v1beta2/language_service.analyze_syntax.js
@@ -23,6 +23,9 @@
 function main(document) {
   // [START language_v1beta2_generated_LanguageService_AnalyzeSyntax_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta2/language_service.annotate_text.js b/samples/generated/v1beta2/language_service.annotate_text.js
@@ -23,6 +23,9 @@
 function main(document, features) {
   // [START language_v1beta2_generated_LanguageService_AnnotateText_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta2/language_service.classify_text.js b/samples/generated/v1beta2/language_service.classify_text.js
@@ -23,6 +23,9 @@
 function main(document) {
   // [START language_v1beta2_generated_LanguageService_ClassifyText_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta2/snippet_metadata.google.cloud.language.v1beta2.json b/samples/generated/v1beta2/snippet_metadata.google.cloud.language.v1beta2.json
@@ -22,7 +22,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 55,
+                    "end": 58,
                     "type": "FULL"
                 }
             ],
@@ -66,7 +66,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 54,
+                    "end": 57,
                     "type": "FULL"
                 }
             ],
@@ -110,7 +110,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 54,
+                    "end": 57,
                     "type": "FULL"
                 }
             ],
@@ -154,7 +154,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 54,
+                    "end": 57,
                     "type": "FULL"
                 }
             ],
@@ -198,7 +198,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 50,
+                    "end": 53,
                     "type": "FULL"
                 }
             ],
@@ -238,7 +238,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 59,
+                    "end": 62,
                     "type": "FULL"
                 }
             ],
diff --git a/src/v1/language_service_client.ts b/src/v1/language_service_client.ts
@@ -226,7 +226,8 @@ export class LanguageServiceClient {
       const apiCall = this._gaxModule.createApiCall(
         callPromise,
         this._defaults[methodName],
-        descriptor
+        descriptor,
+        this._opts.fallback
       );
 
       this.innerApiCalls[methodName] = apiCall;
diff --git a/src/v1beta2/language_service_client.ts b/src/v1beta2/language_service_client.ts
@@ -226,7 +226,8 @@ export class LanguageServiceClient {
       const apiCall = this._gaxModule.createApiCall(
         callPromise,
         this._defaults[methodName],
-        descriptor
+        descriptor,
+        this._opts.fallback
       );
 
       this.innerApiCalls[methodName] = apiCall;
diff --git a/test/gapic_language_service_v1.ts b/test/gapic_language_service_v1.ts
diff --git a/test/gapic_language_service_v1beta2.ts b/test/gapic_language_service_v1beta2.ts

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`"segments": [`
`23`	`23`	`{`
`24`	`24`	`"start": 25,`
`25`		`- "end": 54,`
	`25`	`+ "end": 57,`
`26`	`26`	`"type": "FULL"`
`27`	`27`	`}`
`28`	`28`	`],`
`@@ -66,7 +66,7 @@`
`66`	`66`	`"segments": [`
`67`	`67`	`{`
`68`	`68`	`"start": 25,`
`69`		`- "end": 54,`
	`69`	`+ "end": 57,`
`70`	`70`	`"type": "FULL"`
`71`	`71`	`}`
`72`	`72`	`],`
`@@ -110,7 +110,7 @@`
`110`	`110`	`"segments": [`
`111`	`111`	`{`
`112`	`112`	`"start": 25,`
`113`		`- "end": 54,`
	`113`	`+ "end": 57,`
`114`	`114`	`"type": "FULL"`
`115`	`115`	`}`
`116`	`116`	`],`
`@@ -154,7 +154,7 @@`
`154`	`154`	`"segments": [`
`155`	`155`	`{`
`156`	`156`	`"start": 25,`
`157`		`- "end": 54,`
	`157`	`+ "end": 57,`
`158`	`158`	`"type": "FULL"`
`159`	`159`	`}`
`160`	`160`	`],`
`@@ -198,7 +198,7 @@`
`198`	`198`	`"segments": [`
`199`	`199`	`{`
`200`	`200`	`"start": 25,`
`201`		`- "end": 50,`
	`201`	`+ "end": 53,`
`202`	`202`	`"type": "FULL"`
`203`	`203`	`}`
`204`	`204`	`],`
`@@ -238,7 +238,7 @@`
`238`	`238`	`"segments": [`
`239`	`239`	`{`
`240`	`240`	`"start": 25,`
`241`		`- "end": 59,`
	`241`	`+ "end": 62,`
`242`	`242`	`"type": "FULL"`
`243`	`243`	`}`
`244`	`244`	`],`