Correct MAINTENANCE_TODO about TRANSIENT_ATTACHMENT (#4633)

kainino0x · web-flow · commit 1a90098810cf · 2026-04-28T10:14:11.000Z
diff --git a/src/webgpu/api/operation/render_pass/resolve.spec.ts b/src/webgpu/api/operation/render_pass/resolve.spec.ts
@@ -59,7 +59,7 @@ Test basic render pass resolve behavior for combinations of:
     const { colorFormat } = t.params;
     t.skipIfTextureFormatNotSupported(colorFormat);
     t.skipIfTextureFormatNotResolvable(colorFormat);
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if (t.params.transientColorAttachment || t.params.transientDepthStencilAttachment) {
       t.skipIfTransientAttachmentNotSupported();
     }
diff --git a/src/webgpu/api/operation/render_pass/transient_attachment.spec.ts b/src/webgpu/api/operation/render_pass/transient_attachment.spec.ts
@@ -14,7 +14,7 @@ g.test('increasing_attachments_count')
   `
   )
   .fn(t => {
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     t.skipIfTransientAttachmentNotSupported();
 
     const maxAttachments = t.device.limits.maxColorAttachments;
@@ -58,7 +58,7 @@ g.test('overlapping_transient_attachments')
   `
   )
   .fn(t => {
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     t.skipIfTransientAttachmentNotSupported();
 
     const encoder = t.device.createCommandEncoder();
diff --git a/src/webgpu/api/validation/createBindGroup.spec.ts b/src/webgpu/api/validation/createBindGroup.spec.ts
@@ -220,7 +220,7 @@ g.test('texture_binding_must_have_correct_usage')
       "The test requires 'r32float' multisampled support which compat mode doesn't guarantee."
     );
 
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
       t.skipIfTransientAttachmentNotSupported();
     }
@@ -803,7 +803,7 @@ g.test('storage_texture,usage')
 
     const usage = usage0 | usage1;
 
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
       t.skipIfTransientAttachmentNotSupported();
     }
@@ -1242,7 +1242,7 @@ g.test('external_texture,texture_view,usage')
 
     const usage = usage0 | usage1;
 
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
       t.skipIfTransientAttachmentNotSupported();
     }
diff --git a/src/webgpu/api/validation/createTexture.spec.ts b/src/webgpu/api/validation/createTexture.spec.ts
@@ -358,7 +358,7 @@ g.test('sampleCount,valid_sampleCount_with_other_parameter_varies')
     if ((usage & GPUConst.TextureUsage.RENDER_ATTACHMENT) !== 0) {
       t.skipIfTextureFormatNotUsableAsRenderAttachment(format);
     }
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
       t.skipIfTransientAttachmentNotSupported();
     }
@@ -1035,7 +1035,7 @@ g.test('texture_usage')
       usage,
     };
 
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
       t.skipIfTransientAttachmentNotSupported();
     }
@@ -1075,7 +1075,7 @@ g.test('depthOrArrayLayers_and_mipLevelCount_for_transient_attachments')
       .combine('mipLevelCount', [1, 2])
   )
   .fn(t => {
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     t.skipIfTransientAttachmentNotSupported();
 
     const { format, depthOrArrayLayers, mipLevelCount } = t.params;
diff --git a/src/webgpu/api/validation/render_pass/render_pass_descriptor.spec.ts b/src/webgpu/api/validation/render_pass/render_pass_descriptor.spec.ts
@@ -741,7 +741,7 @@ g.test('color_attachments,loadOp_storeOp')
     t.skipIfTextureFormatNotSupported(format);
     t.skipIfTextureFormatNotUsableAsRenderAttachment(format);
 
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if (transientTexture) {
       t.skipIfTransientAttachmentNotSupported();
     }
@@ -1129,7 +1129,7 @@ g.test('depth_stencil_attachment,loadOp_storeOp_match_depthReadOnly_stencilReadO
 
     t.skipIfTextureFormatNotSupported(format);
 
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if (transientTexture) {
       t.skipIfTransientAttachmentNotSupported();
     }
diff --git a/src/webgpu/api/validation/texture/bgra8unorm_storage.spec.ts b/src/webgpu/api/validation/texture/bgra8unorm_storage.spec.ts
@@ -106,7 +106,7 @@ Test that it is invalid to configure a GPUCanvasContext to 'GPUStorageBinding' u
   .fn(t => {
     const { canvasType, usage } = t.params;
 
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
       t.skipIfTransientAttachmentNotSupported();
     }
@@ -155,7 +155,7 @@ with 'bgra8unorm-storage' enabled.
   .fn(t => {
     const { canvasType, usage } = t.params;
 
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
       t.skipIfTransientAttachmentNotSupported();
     }
diff --git a/src/webgpu/gpu_test.ts b/src/webgpu/gpu_test.ts
@@ -675,7 +675,7 @@ export class GPUTestBase extends Fixture<GPUTestSubcaseBatchState> {
   }
 
   /** Skips this test case if the GPUTextureUsage `TRANSIENT_ATTACHMENT` is *not* supported. */
-  // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+  // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
   skipIfTransientAttachmentNotSupported() {
     const isTransientAttachmentSupported = 'TRANSIENT_ATTACHMENT' in GPUTextureUsage;
     this.skipIf(
diff --git a/src/webgpu/idl/constants/flags.spec.ts b/src/webgpu/idl/constants/flags.spec.ts
@@ -46,7 +46,7 @@ const kTextureUsageExp: {
   TRANSIENT_ATTACHMENT: 0x20,
 };
 g.test('TextureUsage,count').fn(t => {
-  // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+  // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
   if (!('TRANSIENT_ATTACHMENT' in GPUTextureUsage)) {
     delete kTextureUsageExp.TRANSIENT_ATTACHMENT;
   }
@@ -57,7 +57,7 @@ g.test('TextureUsage,values')
   .fn(t => {
     const { key } = t.params;
 
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     t.skipIf(key === 'TRANSIENT_ATTACHMENT' && !('TRANSIENT_ATTACHMENT' in GPUTextureUsage));
 
     t.assertMember(GPUTextureUsage, kTextureUsageExp, key);
diff --git a/src/webgpu/web_platform/canvas/configure.spec.ts b/src/webgpu/web_platform/canvas/configure.spec.ts
@@ -220,7 +220,7 @@ g.test('usage')
   .fn(t => {
     const { canvasType, usage } = t.params;
 
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
       t.skipIfTransientAttachmentNotSupported();
     }
@@ -355,7 +355,7 @@ g.test('invalid_usage')
   .fn(t => {
     const { canvasType, format, usage } = t.params;
 
-    // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
+    // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
     if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
       t.skipIfTransientAttachmentNotSupported();
     }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ Test basic render pass resolve behavior for combinations of:`
`59`	`59`	`const { colorFormat } = t.params;`
`60`	`60`	`t.skipIfTextureFormatNotSupported(colorFormat);`
`61`	`61`	`t.skipIfTextureFormatNotResolvable(colorFormat);`
`62`		`- // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.`
	`62`	`+ // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.`
`63`	`63`	`if (t.params.transientColorAttachment \|\| t.params.transientDepthStencilAttachment) {`
`64`	`64`	`t.skipIfTransientAttachmentNotSupported();`
`65`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ g.test('increasing_attachments_count')`
`14`	`14`	`
`15`	`15`	`)`
`16`	`16`	`.fn(t => {`
`17`		`- // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.`
	`17`	`+ // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.`
`18`	`18`	`t.skipIfTransientAttachmentNotSupported();`
`19`	`19`
`20`	`20`	`const maxAttachments = t.device.limits.maxColorAttachments;`
`@@ -58,7 +58,7 @@ g.test('overlapping_transient_attachments')`
`58`	`58`	`
`59`	`59`	`)`
`60`	`60`	`.fn(t => {`
`61`		`- // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.`
	`61`	`+ // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.`
`62`	`62`	`t.skipIfTransientAttachmentNotSupported();`
`63`	`63`
`64`	`64`	`const encoder = t.device.createCommandEncoder();`
Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,7 @@ g.test('sampleCount,valid_sampleCount_with_other_parameter_varies')`
`358`	`358`	`if ((usage & GPUConst.TextureUsage.RENDER_ATTACHMENT) !== 0) {`
`359`	`359`	`t.skipIfTextureFormatNotUsableAsRenderAttachment(format);`
`360`	`360`	`}`
`361`		`- // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.`
	`361`	`+ // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.`
`362`	`362`	`if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {`
`363`	`363`	`t.skipIfTransientAttachmentNotSupported();`
`364`	`364`	`}`
`@@ -1035,7 +1035,7 @@ g.test('texture_usage')`
`1035`	`1035`	`usage,`
`1036`	`1036`	`};`
`1037`	`1037`
`1038`		`- // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.`
	`1038`	`+ // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.`
`1039`	`1039`	`if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {`
`1040`	`1040`	`t.skipIfTransientAttachmentNotSupported();`
`1041`	`1041`	`}`
`@@ -1075,7 +1075,7 @@ g.test('depthOrArrayLayers_and_mipLevelCount_for_transient_attachments')`
`1075`	`1075`	`.combine('mipLevelCount', [1, 2])`
`1076`	`1076`	`)`
`1077`	`1077`	`.fn(t => {`
`1078`		`- // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.`
	`1078`	`+ // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.`
`1079`	`1079`	`t.skipIfTransientAttachmentNotSupported();`
`1080`	`1080`
`1081`	`1081`	`const { format, depthOrArrayLayers, mipLevelCount } = t.params;`
Original file line number	Diff line number	Diff line change
`@@ -741,7 +741,7 @@ g.test('color_attachments,loadOp_storeOp')`
`741`	`741`	`t.skipIfTextureFormatNotSupported(format);`
`742`	`742`	`t.skipIfTextureFormatNotUsableAsRenderAttachment(format);`
`743`	`743`
`744`		`- // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.`
	`744`	`+ // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.`
`745`	`745`	`if (transientTexture) {`
`746`	`746`	`t.skipIfTransientAttachmentNotSupported();`
`747`	`747`	`}`
`@@ -1129,7 +1129,7 @@ g.test('depth_stencil_attachment,loadOp_storeOp_match_depthReadOnly_stencilReadO`
`1129`	`1129`
`1130`	`1130`	`t.skipIfTextureFormatNotSupported(format);`
`1131`	`1131`
`1132`		`- // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.`
	`1132`	`+ // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.`
`1133`	`1133`	`if (transientTexture) {`
`1134`	`1134`	`t.skipIfTransientAttachmentNotSupported();`
`1135`	`1135`	`}`
Original file line number	Diff line number	Diff line change
`@@ -675,7 +675,7 @@ export class GPUTestBase extends Fixture<GPUTestSubcaseBatchState> {`
`675`	`675`	`}`
`676`	`676`
`677`	`677`	/** Skips this test case if the GPUTextureUsage `TRANSIENT_ATTACHMENT` is not supported. */
`678`		`- // MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.`
	`678`	`+ // MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.`
`679`	`679`	`skipIfTransientAttachmentNotSupported() {`
`680`	`680`	`const isTransientAttachmentSupported = 'TRANSIENT_ATTACHMENT' in GPUTextureUsage;`
`681`	`681`	`this.skipIf(`