Skip to content

Commit 3b327eb

Browse files
authored
Check that an unused, destroyed occlusion query causes submit to fail (#4639)
See gpuweb/gpuweb#6247
1 parent cea97a8 commit 3b327eb

2 files changed

Lines changed: 16 additions & 0 deletions

File tree

src/webgpu/api/validation/queue/destroyed/query_set.spec.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,21 @@ Tests that use a destroyed query set in occlusion query on render pass encoder.
2525
encoder.validateFinishAndSubmitGivenState(t.params.querySetState);
2626
});
2727

28+
g.test('unusedOcclusionQuery')
29+
.desc(
30+
`
31+
Tests that use a destroyed query set in occlusion query on render pass encoder, even if no beginOcclusionQuery calls are done.
32+
- x= {destroyed, not destroyed (control case)}
33+
`
34+
)
35+
.paramsSubcasesOnly(u => u.combine('querySetState', ['valid', 'destroyed'] as const))
36+
.fn(t => {
37+
const occlusionQuerySet = vtu.createQuerySetWithState(t, t.params.querySetState);
38+
39+
const encoder = t.createEncoder('render pass', { occlusionQuerySet });
40+
encoder.validateFinishAndSubmitGivenState(t.params.querySetState);
41+
});
42+
2843
g.test('timestamps')
2944
.desc(
3045
`

src/webgpu/listing_meta.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -734,6 +734,7 @@
734734
"webgpu:api,validation,queue,destroyed,query_set:beginOcclusionQuery:*": { "subcaseMS": 17.401 },
735735
"webgpu:api,validation,queue,destroyed,query_set:resolveQuerySet:*": { "subcaseMS": 16.401 },
736736
"webgpu:api,validation,queue,destroyed,query_set:timestamps:*": { "subcaseMS": 0.901 },
737+
"webgpu:api,validation,queue,destroyed,query_set:unusedOcclusionQuery:*": { "subcaseMS": 8.855 },
737738
"webgpu:api,validation,queue,destroyed,texture:beginRenderPass:*": { "subcaseMS": 0.350 },
738739
"webgpu:api,validation,queue,destroyed,texture:copyBufferToTexture:*": { "subcaseMS": 16.550 },
739740
"webgpu:api,validation,queue,destroyed,texture:copyTextureToBuffer:*": { "subcaseMS": 15.900 },

0 commit comments

Comments
 (0)