Skip to content

Commit fda9dfa

Browse files
fix(dfir_lang): fix lattice_reduce dropping write_tick_end, use fully qualified RefCell::take
- Fix lattice_reduce to pass through write_tick_end from the delegated reduce operator (was silently dropped by `..` destructuring pattern). - Use fully qualified `RefCell::take()` syntax in state_by tick reset for clarity. - Remove `#[non_exhaustive]` from OperatorWriteOutput and add doc comment warning against using `..` in destructuring patterns for delegating operators. Co-authored-by: Infinity 🤖 <infinity@hydro.run>
1 parent 9717a91 commit fda9dfa

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

dfir_lang/src/graph/ops/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,9 @@ impl Debug for OperatorConstraints {
111111
}
112112

113113
/// The code generated and returned by a [`OperatorConstraints::write_fn`].
114+
/// **Important**: When destructuring this struct in delegating operators, list all fields
115+
/// explicitly rather than using `..` to ensure new fields are not silently dropped.
114116
#[derive(Default)]
115-
#[non_exhaustive]
116117
pub struct OperatorWriteOutput {
117118
/// Code which runs once outside any subgraphs, BEFORE subgraphs are initialized,
118119
/// to set up any external state (state API, chanels, network connections, etc.)

0 commit comments

Comments
 (0)