Staging: extend GH-21687 fix for by-val regression#53
Closed
Conversation
Check ZEND_ACC_READONLY before creating the reference. For by-ref callbacks, throw the same "Cannot acquire reference to readonly property" error foreach uses. For by-val callbacks, copy the value into a temp so MAKE_REF does not corrupt the slot. Closes phpGH-21687
Owner
Author
|
Validated; pushed to upstream php#21690. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging extension to php#21690 for CI validation before force-push to the upstream PR branch. Adds by-val callback handling on readonly properties (only by-ref throws now, by-val copies to a temp).