Merge pull request #120 from keboola/CM-713-ondra

configDefinition for ACTION_GET_PROPERTIES_METADATA

Author: ondrajodas

phpstan.neon

@@ -3,4 +3,5 @@ parameters:
     ignoreErrors:
         - '#Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition\:\:ignoreExtraKeys\(\).#'
         - '#Cannot call method integerNode\(\) on Symfony\\Component\\Config\\Definition\\Builder\\NodeParentInterface\|null\.#'
+        - '#Cannot call method scalarNode\(\) on Symfony\\Component\\Config\\Definition\\Builder\\NodeParentInterface\|null\.#'
         - '#logger of class Keboola\\Google\\ClientBundle\\Google\\RestApi constructor expects Monolog\\Logger\|null, Psr\\Log\\LoggerInterface given\.#'

src/Component.php

@@ -14,6 +14,7 @@
 use Keboola\GoogleAnalyticsExtractor\Configuration\Config;
 use Keboola\GoogleAnalyticsExtractor\Configuration\ConfigDefinition;
 use Keboola\GoogleAnalyticsExtractor\Configuration\ConfigGetProfilesPropertiesDefinition;
+use Keboola\GoogleAnalyticsExtractor\Configuration\ConfigGetPropertiesMetadataDefinition;
 use Keboola\GoogleAnalyticsExtractor\Configuration\MigrateConfiguration;
 use Keboola\GoogleAnalyticsExtractor\Configuration\OldConfigDefinition;
 use Keboola\GoogleAnalyticsExtractor\Exception\ApplicationException;
@@ -225,6 +226,8 @@ protected function getConfigDefinitionClass(): string
         switch ($action) {
             case self::ACTION_GET_PROFILES_PROPERTIES:
                 return ConfigGetProfilesPropertiesDefinition::class;
+            case self::ACTION_GET_PROPERTIES_METADATA:
+                return ConfigGetPropertiesMetadataDefinition::class;
             default:
                 $config = $this->getRawConfig();
                 if (array_key_exists('queries', $config['parameters'])) {

src/Configuration/ConfigGetPropertiesMetadataDefinition.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Keboola\GoogleAnalyticsExtractor\Configuration;
+
+use Keboola\Component\Config\BaseConfigDefinition;
+use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
+
+class ConfigGetPropertiesMetadataDefinition extends BaseConfigDefinition
+{
+    public function getParametersDefinition(): ArrayNodeDefinition
+    {
+        $parametersNode = parent::getParametersDefinition();
+
+        $parametersNode
+            ->children()
+                ->arrayNode('properties')
+                    ->arrayPrototype()
+                    ->children()
+                        ->scalarNode('accountKey')->isRequired()->end()
+                        ->scalarNode('accountName')->isRequired()->end()
+                        ->scalarNode('propertyKey')->isRequired()->end()
+                        ->scalarNode('propertyName')->isRequired()->end()
+                    ->end()
+                ->end()
+            ->end()
+        ;
+
+        return $parametersNode;
+    }
+}

tests/functional/get-properties-metadata-sync-action/source/data/config.json

@@ -9,9 +9,6 @@
     }
   },
   "parameters": {
-    "outputBucket": "in.c-ex-google-analytics-cfg",
-    "outputTable": "test",
-    "retriesCount": 1,
     "properties": [
       {
         "accountKey": "accounts/185283969",