skip orphaned manifests

Author: ondrajodas

src/Extractor/Extractor.php

@@ -60,10 +60,10 @@ public function runProfiles(array $query, array $profiles): array
 
         if (isset($query['query'])) {
             $outputCsv = $this->output->createReport($query);
-            $this->output->createManifest($outputCsv->getFilename(), $query, ['id'], true);
             $this->logger->info(sprintf("Running query '%s'", $query['outputTable']));
 
             $downloadedProfiles = false;
+            $manifestCreated = false;
             foreach ($profiles as $profile) {
                 $this->logger->info(sprintf('Profile "%s" export started.', $profile['id']));
                 $apiQuery = $query;
@@ -130,7 +130,16 @@ public function runProfiles(array $query, array $profiles): array
                     }
                 }
 
-                $paginator->paginate($apiQuery, $report, $outputCsv);
+                $rowCount = $paginator->paginate($apiQuery, $report, $outputCsv);
+                if ($rowCount > 0 && !$manifestCreated) {
+                    $this->output->createManifest(
+                        $outputCsv->getFilename(),
+                        $query,
+                        ['id'],
+                        true,
+                    );
+                    $manifestCreated = true;
+                }
 
                 $status[$query['outputTable']][$profile['id']] = 'ok';
             }
@@ -159,10 +168,10 @@ public function runProperties(array $query, array $properties): array
             $query['query']['endpoint'] = 'properties';
 
             $outputCsv = $this->output->createReport($query);
-            $this->output->createManifest($outputCsv->getFilename(), $query, ['id'], true, 'idProperty');
             $this->logger->info(sprintf("Running query '%s'", $query['outputTable']));
 
             $downloadedProperties = false;
+            $manifestCreated = false;
             foreach ($properties as $property) {
                 $this->logger->info(sprintf('Property "%s" export started.', $property['propertyName']));
                 if (!empty($query['query']['viewId'])
@@ -199,7 +208,17 @@ public function runProperties(array $query, array $properties): array
                     continue;
                 }
 
-                $paginator->paginate($apiQuery, $report, $outputCsv);
+                $rowCount = $paginator->paginate($apiQuery, $report, $outputCsv);
+                if ($rowCount > 0 && !$manifestCreated) {
+                    $this->output->createManifest(
+                        $outputCsv->getFilename(),
+                        $query,
+                        ['id'],
+                        true,
+                        'idProperty',
+                    );
+                    $manifestCreated = true;
+                }
 
                 $status[$query['outputTable']][$property['propertyKey']] = 'ok';
             }

src/Extractor/Paginator/IPaginator.php

@@ -12,5 +12,5 @@ interface IPaginator
 {
     public function getOutput(): Output;
     public function getClient(): Client;
-    public function paginate(array $query, array $report, CsvFile $csvFile): void;
+    public function paginate(array $query, array $report, CsvFile $csvFile): int;
 }

src/Extractor/Paginator/ProfilesPaginator.php

@@ -34,7 +34,7 @@ public function getClient(): Client
         return $this->client;
     }
 
-    public function paginate(array $query, array $report, CsvFile $csvFile): void
+    public function paginate(array $query, array $report, CsvFile $csvFile): int
     {
         $counter = 0;
         do {
@@ -60,6 +60,8 @@ public function paginate(array $query, array $report, CsvFile $csvFile): void
             }
             $query = $nextQuery;
         } while ($query);
+
+        return $counter;
     }
 
     private function getStartIndex(string $link): string

src/Extractor/Paginator/PropertiesPaginator.php

@@ -44,7 +44,7 @@ public function setProperty(array $property): self
         return $this;
     }
 
-    public function paginate(array $query, array $report, CsvFile $csvFile): void
+    public function paginate(array $query, array $report, CsvFile $csvFile): int
     {
         $localCounter = 0;
         do {
@@ -66,5 +66,7 @@ public function paginate(array $query, array $report, CsvFile $csvFile): void
 
             $query = $nextQuery;
         } while ($report['totals'] > $localCounter);
+
+        return $localCounter;
     }
 }