Add option - keepEmptyRows

Author: ondrajodas

src/Configuration/ConfigDefinition.php

@@ -166,6 +166,7 @@ public function getParametersDefinition(): ArrayNodeDefinition
                         ->end()
                         ->scalarNode('samplingLevel')
                         ->end()
+                        ->booleanNode('keepEmptyRows')->defaultTrue()->end()
                     ->end()
                 ->end()
                 ->scalarNode('outputTable')

src/GoogleAnalytics/Client.php

@@ -260,7 +260,7 @@ private function getPropertyReportRequest(array $query): array
                     'endDate' => date('Y-m-d', (int) strtotime($item['endDate'])),
                 ];
             }, $query['dateRanges']),
-            'keepEmptyRows' => true,
+            'keepEmptyRows' => $query['keepEmptyRows'] ?? true,
             'dimensions' => $query['dimensions'],
             'metrics' => $query['metrics'],
             'offset' => $query['offset'] ?? 0,

tests/Keboola/GoogleAnalyticsExtractor/Configuration/ConfigDefinitionTest.php

@@ -103,6 +103,21 @@ public function testAddSegmentDimension(): void
         $this->assertCount(1, $dimensions);
     }
 
+    public function testKeepEmptyRowsDefaultAndCustom(): void
+    {
+        // Default value (not set in config)
+        $config = $this->config;
+        unset($config['parameters']['query']['keepEmptyRows']);
+        $configData = new Config($config, new ConfigDefinition());
+        $this->assertArrayHasKey('keepEmptyRows', $configData->getQuery());
+        $this->assertTrue($configData->getQuery()['keepEmptyRows']);
+
+        // Set to false
+        $config['parameters']['query']['keepEmptyRows'] = false;
+        $configData = new Config($config, new ConfigDefinition());
+        $this->assertFalse($configData->getQuery()['keepEmptyRows']);
+    }
+
     private function getConfig(string $suffix = ''): array
     {
         $config = json_decode((string) file_get_contents($this->dataDir . '/config' . $suffix . '.json'), true);