Merge pull request #11 from keboola/adamvyborny-CM-85-do-not-retry-on-401

Do not retry on 401

Author: AdamVyborny

src/Google/RestApi.php

@@ -322,6 +322,9 @@ protected function decideRetry(int $retries, int $maxRetries, ?ResponseInterface
             if ($statusCode === 400) {
                 return false;
             }
+            if ($statusCode === 401 && $retries > 0) { //allow only one retry for refreshing token
+                return false;
+            }
             if ($statusCode === 403) {
                 return call_user_func($this->backoffCallback403, $response);
             }

tests/RestApiTest.php

@@ -124,7 +124,7 @@ public function testRetries(): void
                     'request' => [
                         'uri' => 'https://www.googleapis.com/auth/invalid-scope',
                         'headers' => [
-                            'User-Agent' => ['GuzzleHttp/6.5.5 curl/7.74.0 PHP/7.4.30'],
+                            'User-Agent' => ['GuzzleHttp/6.5.5 curl/7.74.0 PHP/7.4.33'],
                             'Host' => ['www.googleapis.com'],
                             'Accept' => ['application/json'],
                             'Authorization' => '*****',
@@ -150,6 +150,32 @@ public function testRetries(): void
         }
     }
 
+    public function testDoNotRetryOnWrongCredentials(): void
+    {
+        $testHandler = new TestHandler();
+        $logger = new Logger('Google Rest API tests');
+        $logger->pushHandler($testHandler);
+        $api = new RestApi(
+            $this->getEnv('CLIENT_ID'),
+            $this->getEnv('CLIENT_SECRET') . 'invalid',
+            '',
+            $this->getEnv('REFRESH_TOKEN'),
+            $logger
+        );
+
+        try {
+            $api->request('/oauth2/v3/userinfo');
+        } catch (ClientException $e) {
+            $this->assertStringContainsString('401 Unauthorized', $e->getMessage());
+        }
+
+        $this->assertCount(1, $testHandler->getRecords());
+        $this->assertStringContainsString(
+            'Retrying request (0x) - reason: Unauthorized',
+            $testHandler->getRecords()[0]['message']
+        );
+    }
+
     protected function getEnv(string $name): string
     {
         $value = getenv($name);