Skip to content

Commit 03e5a09

Browse files
vojtabiberleclaude
andcommitted
DMD-942 - Remove WithoutSamples flag
The flag was redundant since samples are opt-in via --with-samples. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 5990cd5 commit 03e5a09

2 files changed

Lines changed: 4 additions & 11 deletions

File tree

  • internal/pkg/service/cli/cmd/llm/export
  • pkg/lib/operation/llm/export

internal/pkg/service/cli/cmd/llm/export/cmd.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ type Flags struct {
1414
StorageAPIToken configmap.Value[string] `configKey:"storage-api-token" configShorthand:"t" configUsage:"storage API token from your project"`
1515
Force configmap.Value[bool] `configKey:"force" configShorthand:"f" configUsage:"skip confirmation when directory contains existing files"`
1616
WithSamples configmap.Value[bool] `configKey:"with-samples" configUsage:"include table data samples in export"`
17-
WithoutSamples configmap.Value[bool] `configKey:"without-samples" configUsage:"exclude table data samples from export"`
1817
SampleLimit configmap.Value[int] `configKey:"sample-limit" configUsage:"maximum number of rows per table sample (default: 100, max: 1000)"`
1918
MaxSamples configmap.Value[int] `configKey:"max-samples" configUsage:"maximum number of tables to sample (default: 50, max: 100)"`
2019
}
@@ -50,11 +49,10 @@ func Command(p dependencies.Provider) *cobra.Command {
5049

5150
// Build options
5251
options := exportOp.Options{
53-
Force: f.Force.Value,
54-
WithSamples: f.WithSamples.Value,
55-
WithoutSamples: f.WithoutSamples.Value,
56-
SampleLimit: f.SampleLimit.Value,
57-
MaxSamples: f.MaxSamples.Value,
52+
Force: f.Force.Value,
53+
WithSamples: f.WithSamples.Value,
54+
SampleLimit: f.SampleLimit.Value,
55+
MaxSamples: f.MaxSamples.Value,
5856
}
5957

6058
// Send cmd successful/failed event

pkg/lib/operation/llm/export/options.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ type Options struct {
1818
Force bool
1919
// WithSamples enables table data samples in export.
2020
WithSamples bool
21-
// WithoutSamples disables table data samples in export.
22-
WithoutSamples bool
2321
// SampleLimit is the maximum number of rows per table sample.
2422
SampleLimit int
2523
// MaxSamples is the maximum number of tables to sample.
@@ -28,9 +26,6 @@ type Options struct {
2826

2927
// ShouldIncludeSamples returns true if samples should be included in the export.
3028
func (o Options) ShouldIncludeSamples() bool {
31-
if o.WithoutSamples {
32-
return false
33-
}
3429
return o.WithSamples
3530
}
3631

0 commit comments

Comments
 (0)