Merge pull request #2517 from keboola/devin/PSGO-57-1769164125-remove-redundant-otel-http-metrics

fix(telemetry): remove redundant OpenTelemetry HTTP server metrics

Author: Matovidlo

docs/telemetry.md

@@ -43,38 +43,6 @@ the [prometheus.ServeMetrics](../internal/pkg/telemetry/metric/prometheus/promet
 |-----------------------|--------------------------------------------------------------------------------------------------|
 | `http.server.request` | HTTP request. Attributes `keboola.*` contain info about stack, project and token, if applicable. |
 
-### Metrics
-
-| Span                                         | Description               |
-|----------------------------------------------|---------------------------|
-| `keboola.go.http.server.duration`            | Duration of HTTP request. |
-| `keboola.go.http.server.request.size.count`  | Request content length.   |
-| `keboola.go.http.server.response.size.count` | Response content length.  |
-
-#### Apdex
-
-[Apdex](https://en.wikipedia.org/wiki/Apdex) metric measure user satisfaction as a value `0.0-1.0`:
-
-- Parameter `T` defines threshold for `satisfied` request duration in `ms`.
-- `4T` is threshold for `tolerating` request duration.
-- Longer durations are considered as `frustrated`, as well as requests with a status code `>= 500` (server errors).
-
-Apdex is reported cumulatively from [Go code](../internal/pkg/service/common/httpserver/middleware/otel_apdex.go).
-The following metrics are generated:
-
-| Span                                          | Description                           |
-|-----------------------------------------------|---------------------------------------|
-| `keboola_go_http_server_apdex_count.count`    | Apdex - total count of requests.      |
-| `keboola_go_http_server_apdex_500_sum.count`  | Apdex sum for: T=`500ms` 4T=`2000ms`  |
-| `keboola_go_http_server_apdex_1000_sum.count` | Apdex sum for: T=`1000ms` 4T=`4000ms` |
-| `keboola_go_http_server_apdex_2000_sum.count` | Apdex sum for: T=`2000ms` 4T=`8000ms` |
-
-Final Apdex value is calculated as follows:
-
-```
-keboola_go_http_server_apdex_<T>_sum.count / keboola_go_http_server_apdex_count.count
-```
-
 ## HTTP Client
 
 Client telemetry is implemented in the [keboola-sdk-go](https://github.com/keboola/keboola-sdk-go) repository, in

go.mod

@@ -70,7 +70,6 @@ require (
 	github.com/spf13/viper v1.21.0
 	github.com/stretchr/testify v1.11.1
 	github.com/umisama/go-regexpcache v0.0.0-20150417035358-2444a542492f
-	github.com/urfave/negroni/v3 v3.1.1
 	github.com/valyala/fasthttp v1.68.0
 	github.com/valyala/fastjson v1.6.4
 	github.com/writeas/go-strip-markdown/v2 v2.1.1

go.sum

@@ -901,8 +901,6 @@ github.com/umisama/go-regexpcache v0.0.0-20150417035358-2444a542492f h1:haUDHoDE
 github.com/umisama/go-regexpcache v0.0.0-20150417035358-2444a542492f/go.mod h1:YTm0hcnGJEKJOLVM4x0PvO8p43r7DANkXRNiONPfWIM=
 github.com/urfave/cli/v2 v2.27.7 h1:bH59vdhbjLv3LAvIu6gd0usJHgoTTPhCFib8qqOwXYU=
 github.com/urfave/cli/v2 v2.27.7/go.mod h1:CyNAG/xg+iAOg0N4MPGZqVmv2rCoP267496AOXUZjA4=
-github.com/urfave/negroni/v3 v3.1.1 h1:6MS4nG9Jk/UuCACaUlNXCbiKa0ywF9LXz5dGu09v8hw=
-github.com/urfave/negroni/v3 v3.1.1/go.mod h1:jWvnX03kcSjDBl/ShB0iHvx5uOs7mAzZXW+JvJ5XYAs=
 github.com/valyala/bytebufferpool v1.0.0 h1:GqA5TC/0021Y/b9FG4Oi9Mr3q7XYx6KllzawFIhcdPw=
 github.com/valyala/bytebufferpool v1.0.0/go.mod h1:6bBcMArwyJ5K/AmCkWv1jt77kVWyCJ6HpOuEn7z0Csc=
 github.com/valyala/fasthttp v1.68.0 h1:v12Nx16iepr8r9ySOwqI+5RBJ/DqTxhOy1HrHoDFnok=