Skip to content

Commit 663f2a2

Browse files
fix(telemetry): remove Apdex middleware to align with go-monorepo
Remove the OpenTelemetryApdex middleware that creates redundant HTTP server metrics. This aligns with go-monorepo PR #304 which removes the same functionality. Changes: - Delete otel_apdex.go and otel_apdex_test.go - Remove OpenTelemetryApdex middleware registration from httpserver.go - Update otel_test.go to remove Apdex-related test cases - Update telemetry.md to remove Apdex documentation Eliminated metrics: - keboola_go_http_server_apdex_count - keboola_go_http_server_apdex_500_sum - keboola_go_http_server_apdex_1000_sum - keboola_go_http_server_apdex_2000_sum Fixes PSGO-57 Co-Authored-By: Martin Vasko <Matovidlo2@gmail.com>
1 parent b70bcaa commit 663f2a2

5 files changed

Lines changed: 91 additions & 513 deletions

File tree

docs/telemetry.md

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -43,30 +43,6 @@ the [prometheus.ServeMetrics](../internal/pkg/telemetry/metric/prometheus/promet
4343
|-----------------------|--------------------------------------------------------------------------------------------------|
4444
| `http.server.request` | HTTP request. Attributes `keboola.*` contain info about stack, project and token, if applicable. |
4545

46-
#### Apdex
47-
48-
[Apdex](https://en.wikipedia.org/wiki/Apdex) metric measure user satisfaction as a value `0.0-1.0`:
49-
50-
- Parameter `T` defines threshold for `satisfied` request duration in `ms`.
51-
- `4T` is threshold for `tolerating` request duration.
52-
- Longer durations are considered as `frustrated`, as well as requests with a status code `>= 500` (server errors).
53-
54-
Apdex is reported cumulatively from [Go code](../internal/pkg/service/common/httpserver/middleware/otel_apdex.go).
55-
The following metrics are generated:
56-
57-
| Span | Description |
58-
|-----------------------------------------------|---------------------------------------|
59-
| `keboola_go_http_server_apdex_count.count` | Apdex - total count of requests. |
60-
| `keboola_go_http_server_apdex_500_sum.count` | Apdex sum for: T=`500ms` 4T=`2000ms` |
61-
| `keboola_go_http_server_apdex_1000_sum.count` | Apdex sum for: T=`1000ms` 4T=`4000ms` |
62-
| `keboola_go_http_server_apdex_2000_sum.count` | Apdex sum for: T=`2000ms` 4T=`8000ms` |
63-
64-
Final Apdex value is calculated as follows:
65-
66-
```
67-
keboola_go_http_server_apdex_<T>_sum.count / keboola_go_http_server_apdex_count.count
68-
```
69-
7046
## HTTP Client
7147

7248
Client telemetry is implemented in the [keboola-sdk-go](https://github.com/keboola/keboola-sdk-go) repository, in

internal/pkg/service/common/httpserver/httpserver.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ func New(ctx context.Context, d dependencies, cfg Config) *HTTPServer {
5959
middlewares = append(middlewares,
6060
middleware.Logger(server.logger),
6161
middleware.OpenTelemetry(tel.TracerProvider(), tel.MeterProvider(), middlewareCfg),
62-
middleware.OpenTelemetryApdex(tel.MeterProvider()),
6362
)
6463

6564
// Add gzip compression if enabled

internal/pkg/service/common/httpserver/middleware/otel_apdex.go

Lines changed: 0 additions & 101 deletions
This file was deleted.

internal/pkg/service/common/httpserver/middleware/otel_apdex_test.go

Lines changed: 0 additions & 108 deletions
This file was deleted.

0 commit comments

Comments
 (0)