DMD-920 - Simplify processor code

- Remove unnecessary jobOutputCount variable that was only used for logging
- Use strings.Builder in buildTableUID and buildTransformationUID to
  prevent string reallocations

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: vojtabiberle

internal/pkg/llm/twinformat/fetcher_test.go

@@ -5,7 +5,6 @@ import (
 	"testing"
 
 	"github.com/jarcoal/httpmock"
-	"github.com/keboola/go-utils/pkg/orderedmap"
 	"github.com/keboola/keboola-sdk-go/v2/pkg/client"
 	"github.com/keboola/keboola-sdk-go/v2/pkg/keboola"
 	"github.com/stretchr/testify/assert"
@@ -223,208 +222,6 @@ func TestFetchJobsQueue(t *testing.T) {
 	assert.Equal(t, "error", jobs[1].Status)
 }
 
-func TestFetchTransformationConfigs(t *testing.T) {
-	t.Parallel()
-
-	fetcher, transport := newTestFetcher(t)
-	branchID := keboola.BranchID(123)
-
-	// Create config content using orderedmap
-	configContent := orderedmap.New()
-	storageSection := orderedmap.New()
-	inputSection := orderedmap.New()
-	inputTables := []any{
-		map[string]any{
-			"source":      "in.c-bucket.source-table",
-			"destination": "source_table",
-		},
-	}
-	inputSection.Set("tables", inputTables)
-	storageSection.Set("input", inputSection.ToMap())
-
-	outputSection := orderedmap.New()
-	outputTables := []any{
-		map[string]any{
-			"source":      "result_table",
-			"destination": "out.c-bucket.result",
-		},
-	}
-	outputSection.Set("tables", outputTables)
-	storageSection.Set("output", outputSection.ToMap())
-	configContent.Set("storage", storageSection.ToMap())
-
-	paramsSection := orderedmap.New()
-	blocks := []any{
-		map[string]any{
-			"name": "Block 1",
-			"codes": []any{
-				map[string]any{
-					"name":   "Code 1",
-					"script": "SELECT * FROM source_table;",
-				},
-			},
-		},
-	}
-	paramsSection.Set("blocks", blocks)
-	configContent.Set("parameters", paramsSection.ToMap())
-
-	// Mock components response - must include transformation and non-transformation components
-	transport.RegisterResponder(
-		http.MethodGet,
-		`=~/v2/storage/branch/123/components`,
-		httpmock.NewJsonResponderOrPanic(200, []*keboola.ComponentWithConfigs{
-			{
-				Component: keboola.Component{
-					ComponentKey: keboola.ComponentKey{ID: "keboola.snowflake-transformation"},
-					Type:         "transformation",
-					Name:         "Snowflake Transformation",
-					Flags:        []string{"genericCodeBlocksUI"},
-				},
-				Configs: []*keboola.ConfigWithRows{
-					{
-						Config: &keboola.Config{
-							ConfigKey: keboola.ConfigKey{
-								BranchID:    branchID,
-								ComponentID: "keboola.snowflake-transformation",
-								ID:          "config-1",
-							},
-							Name:        "Test Transformation",
-							Description: "A test transformation",
-							Content:     configContent,
-						},
-					},
-				},
-			},
-			{
-				Component: keboola.Component{
-					ComponentKey: keboola.ComponentKey{ID: "keboola.ex-db-mysql"},
-					Type:         "extractor",
-					Name:         "MySQL Extractor",
-				},
-				Configs: []*keboola.ConfigWithRows{
-					{
-						Config: &keboola.Config{
-							ConfigKey: keboola.ConfigKey{
-								BranchID:    branchID,
-								ComponentID: "keboola.ex-db-mysql",
-								ID:          "config-extractor",
-							},
-							Name:    "MySQL Extraction",
-							Content: orderedmap.New(),
-						},
-					},
-				},
-			},
-		}),
-	)
-
-	configs, err := fetcher.FetchTransformationConfigs(t.Context(), branchID)
-	require.NoError(t, err)
-
-	// Should only have transformation configs, not extractors
-	assert.Len(t, configs, 1)
-	assert.Equal(t, "Test Transformation", configs[0].Name)
-	assert.Equal(t, "keboola.snowflake-transformation", configs[0].ComponentID)
-	assert.Len(t, configs[0].InputTables, 1)
-	assert.Equal(t, "in.c-bucket.source-table", configs[0].InputTables[0].Source)
-	assert.Len(t, configs[0].OutputTables, 1)
-	assert.Equal(t, "out.c-bucket.result", configs[0].OutputTables[0].Destination)
-	assert.Len(t, configs[0].Blocks, 1)
-	assert.Equal(t, "Block 1", configs[0].Blocks[0].Name)
-}
-
-func TestFetchComponentConfigs(t *testing.T) {
-	t.Parallel()
-
-	fetcher, transport := newTestFetcher(t)
-	branchID := keboola.BranchID(123)
-
-	// Create extractor config content
-	extractorConfig := orderedmap.New()
-	params := orderedmap.New()
-	params.Set("host", "db.example.com")
-	extractorConfig.Set("parameters", params.ToMap())
-
-	// Mock components response
-	transport.RegisterResponder(
-		http.MethodGet,
-		`=~/v2/storage/branch/123/components`,
-		httpmock.NewJsonResponderOrPanic(200, []*keboola.ComponentWithConfigs{
-			{
-				Component: keboola.Component{
-					ComponentKey: keboola.ComponentKey{ID: "keboola.snowflake-transformation"},
-					Type:         "transformation",
-					Name:         "Snowflake Transformation",
-					Flags:        []string{"genericCodeBlocksUI"},
-				},
-				Configs: []*keboola.ConfigWithRows{
-					{
-						Config: &keboola.Config{
-							ConfigKey: keboola.ConfigKey{
-								BranchID:    branchID,
-								ComponentID: "keboola.snowflake-transformation",
-								ID:          "config-1",
-							},
-							Name:    "Test Transformation",
-							Content: orderedmap.New(),
-						},
-					},
-				},
-			},
-			{
-				Component: keboola.Component{
-					ComponentKey: keboola.ComponentKey{ID: "keboola.ex-db-mysql"},
-					Type:         "extractor",
-					Name:         "MySQL Extractor",
-				},
-				Configs: []*keboola.ConfigWithRows{
-					{
-						Config: &keboola.Config{
-							ConfigKey: keboola.ConfigKey{
-								BranchID:    branchID,
-								ComponentID: "keboola.ex-db-mysql",
-								ID:          "config-extractor",
-							},
-							Name:        "MySQL Extraction",
-							Description: "Extract from MySQL",
-							Content:     extractorConfig,
-						},
-					},
-				},
-			},
-			{
-				Component: keboola.Component{
-					ComponentKey: keboola.ComponentKey{ID: keboola.SchedulerComponentID},
-					Type:         "other",
-					Name:         "Scheduler",
-				},
-				Configs: []*keboola.ConfigWithRows{
-					{
-						Config: &keboola.Config{
-							ConfigKey: keboola.ConfigKey{
-								BranchID:    branchID,
-								ComponentID: keboola.SchedulerComponentID,
-								ID:          "scheduler-1",
-							},
-							Name:    "Scheduler Config",
-							Content: orderedmap.New(),
-						},
-					},
-				},
-			},
-		}),
-	)
-
-	configs, err := fetcher.FetchComponentConfigs(t.Context(), branchID)
-	require.NoError(t, err)
-
-	// Should only have non-transformation, non-scheduler configs
-	assert.Len(t, configs, 1)
-	assert.Equal(t, "MySQL Extraction", configs[0].Name)
-	assert.Equal(t, "keboola.ex-db-mysql", configs[0].ComponentID)
-	assert.Equal(t, "extractor", configs[0].ComponentType)
-}
-
 func TestFetchAll(t *testing.T) {
 	t.Parallel()
 

internal/pkg/llm/twinformat/processor.go

@@ -229,9 +229,9 @@ func (p *Processor) buildTableSourceRegistry(ctx context.Context, transformConfi
 	}
 
 	// PRIORITY 3: Job outputs (fallback for tables not declared in configurations)
-	jobOutputCount := p.registerTablesFromJobs(jobs, componentRegistry, registry)
+	p.registerTablesFromJobs(jobs, componentRegistry, registry)
 
-	p.logger.Infof(ctx, "Built table source registry with %d table mappings (%d from jobs as fallback)", len(registry.tableToSource), jobOutputCount)
+	p.logger.Infof(ctx, "Built table source registry with %d table mappings", len(registry.tableToSource))
 	return registry
 }
 
@@ -632,10 +632,18 @@ func formatJobTimePtr(t *iso8601.Time) string {
 
 // buildTableUID builds a table UID from bucket and table name.
 func buildTableUID(bucket, table string) string {
-	return "table:" + bucket + "/" + table
+	var b strings.Builder
+	b.WriteString("table:")
+	b.WriteString(bucket)
+	b.WriteByte('/')
+	b.WriteString(table)
+	return b.String()
 }
 
 // buildTransformationUID builds a transformation UID from a name.
 func buildTransformationUID(name string) string {
-	return "transform:" + name
+	var b strings.Builder
+	b.WriteString("transform:")
+	b.WriteString(name)
+	return b.String()
 }