DMD-921 - Move SanitizeFilename to strhelper package

Move the function to internal/pkg/utils/strhelper so it can be reused
across packages without refactoring.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: vojtabiberle

internal/pkg/llm/twinformat/generator.go

@@ -12,6 +12,7 @@ import (
 	"github.com/keboola/keboola-as-code/internal/pkg/llm/twinformat/writer"
 	"github.com/keboola/keboola-as-code/internal/pkg/log"
 	"github.com/keboola/keboola-as-code/internal/pkg/utils/errors"
+	"github.com/keboola/keboola-as-code/internal/pkg/utils/strhelper"
 	"github.com/keboola/keboola-as-code/internal/pkg/utils/timeutils"
 )
 
@@ -387,7 +388,7 @@ func (g *Generator) buildTransformationIndex(data *ProcessedData) map[string]any
 // generateTransformationMetadata generates a transformation metadata.json file.
 func (g *Generator) generateTransformationMetadata(ctx context.Context, transform *ProcessedTransformation) error {
 	// Create transformation directory with sanitized name for filesystem safety.
-	transformDir := filesystem.Join(g.outputDir, "transformations", sanitizeFilename(transform.Name))
+	transformDir := filesystem.Join(g.outputDir, "transformations", strhelper.SanitizeFilename(transform.Name))
 	if err := g.fs.Mkdir(ctx, transformDir); err != nil {
 		return errors.Errorf("failed to create transformation directory %s: %w", transformDir, err)
 	}
@@ -484,7 +485,7 @@ func (g *Generator) generateTransformationCode(ctx context.Context, transformDir
 			blockNum++
 			// Create filename: 01-block-name.sql
 			ext := languageToExtension(block.Language)
-			filename := fmt.Sprintf("%02d-%s%s", blockNum, sanitizeFilename(code.Name), ext)
+			filename := fmt.Sprintf("%02d-%s%s", blockNum, strhelper.SanitizeFilename(code.Name), ext)
 			filePath := filesystem.Join(codeDir, filename)
 
 			if err := g.mdWriter.Write(ctx, filePath, code.Script); err != nil {
@@ -529,25 +530,6 @@ func buildJobExecutionMap(exec *JobExecution) map[string]any {
 	return result
 }
 
-// sanitizeFilename removes or replaces characters that are not safe for filenames.
-// Returns "unnamed" if the result would be empty.
-func sanitizeFilename(name string) string {
-	// Replace spaces and special characters with hyphens
-	result := make([]byte, 0, len(name))
-	for i := range len(name) {
-		c := name[i]
-		if (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z') || (c >= '0' && c <= '9') || c == '-' || c == '_' {
-			result = append(result, c)
-		} else if c == ' ' {
-			result = append(result, '-')
-		}
-	}
-	if len(result) == 0 {
-		return "unnamed"
-	}
-	return string(result)
-}
-
 // generateJobs generates jobs/index.json and job detail files.
 func (g *Generator) generateJobs(ctx context.Context, data *ProcessedData) error {
 	g.logger.Debugf(ctx, "Generating jobs index and details")

internal/pkg/llm/twinformat/generator_test.go

@@ -39,35 +39,6 @@ func newTestGenerator(t *testing.T) (*Generator, filesystem.Fs) {
 // Helper Function Tests
 // =============================================================================
 
-func TestSanitizeFilename(t *testing.T) {
-	t.Parallel()
-
-	tests := []struct {
-		name     string
-		input    string
-		expected string
-	}{
-		{name: "simple name", input: "orders", expected: "orders"},
-		{name: "with spaces", input: "my file", expected: "my-file"},
-		{name: "with special chars", input: "file@#$%", expected: "file"},
-		{name: "with dashes", input: "my-file", expected: "my-file"},
-		{name: "with underscores", input: "my_file", expected: "my_file"},
-		{name: "mixed", input: "My File (v2)", expected: "My-File-v2"},
-		{name: "numbers", input: "file123", expected: "file123"},
-		{name: "empty string", input: "", expected: "unnamed"},
-		{name: "only special chars", input: "@#$%", expected: "unnamed"},
-		{name: "multiple spaces", input: "a   b", expected: "a---b"},
-	}
-
-	for _, tc := range tests {
-		t.Run(tc.name, func(t *testing.T) {
-			t.Parallel()
-			result := sanitizeFilename(tc.input)
-			assert.Equal(t, tc.expected, result)
-		})
-	}
-}
-
 func TestLanguageToExtension(t *testing.T) {
 	t.Parallel()
 

internal/pkg/utils/strhelper/strhelper.go

@@ -187,3 +187,23 @@ func FilterLines(keep, lines string) string {
 	}
 	return strings.TrimRight(out.String(), "\n")
 }
+
+// SanitizeFilename removes or replaces characters that are not safe for filenames.
+// Only alphanumeric characters, hyphens, and underscores are kept.
+// Spaces are replaced with hyphens.
+// Returns "unnamed" if the result would be empty.
+func SanitizeFilename(name string) string {
+	result := make([]byte, 0, len(name))
+	for i := range len(name) {
+		c := name[i]
+		if (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z') || (c >= '0' && c <= '9') || c == '-' || c == '_' {
+			result = append(result, c)
+		} else if c == ' ' {
+			result = append(result, '-')
+		}
+	}
+	if len(result) == 0 {
+		return "unnamed"
+	}
+	return string(result)
+}

internal/pkg/utils/strhelper/strhelper_test.go

@@ -235,3 +235,32 @@ func TestFilterLines(t *testing.T) {
 		assert.Equal(t, c.expected, FilterLines("^<KEEP>", c.in), "case "+cast.ToString(i))
 	}
 }
+
+func TestSanitizeFilename(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		name     string
+		input    string
+		expected string
+	}{
+		{name: "simple name", input: "orders", expected: "orders"},
+		{name: "with spaces", input: "my file", expected: "my-file"},
+		{name: "with special chars", input: "file@#$%", expected: "file"},
+		{name: "with dashes", input: "my-file", expected: "my-file"},
+		{name: "with underscores", input: "my_file", expected: "my_file"},
+		{name: "mixed", input: "My File (v2)", expected: "My-File-v2"},
+		{name: "numbers", input: "file123", expected: "file123"},
+		{name: "empty string", input: "", expected: "unnamed"},
+		{name: "only special chars", input: "@#$%", expected: "unnamed"},
+		{name: "multiple spaces", input: "a   b", expected: "a---b"},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+			result := SanitizeFilename(tc.input)
+			assert.Equal(t, tc.expected, result)
+		})
+	}
+}