fix: configuration is not required

Author: odinuv

src/Requests/PostEvent/JobData.php

@@ -14,8 +14,8 @@ class JobData implements JsonSerializable
     private string $jobEndTime;
     private string $componentId;
     private string $componentName;
-    private string $configurationId;
-    private string $configurationName;
+    private ?string $configurationId;
+    private ?string $configurationName;
 
     public function __construct(
         string $jobId,
@@ -24,8 +24,8 @@ public function __construct(
         string $jobEndTime,
         string $componentId,
         string $componentName,
-        string $configurationId,
-        string $configurationName
+        ?string $configurationId,
+        ?string $configurationName
     ) {
         $this->jobId = $jobId;
         $this->jobUrl = $jobUrl;
@@ -42,7 +42,7 @@ public function __construct(
      */
     public function jsonSerialize()
     {
-        return [
+        $result = [
             'id' => $this->jobId,
             'url' => $this->jobUrl,
             'startTime' => $this->jobStartTime,
@@ -51,11 +51,14 @@ public function jsonSerialize()
                 'id' => $this->componentId,
                 'name' => $this->componentName,
             ],
-            'configuration' => [
-                'id' => $this->configurationId,
-                'name' => $this->configurationName,
-            ],
             'tasks' => [],
         ];
+        if ($this->configurationId && $this->configurationName) {
+            $result['configuration'] = [
+                'id' => $this->configurationId,
+                'name' => $this->configurationName,
+            ];
+        }
+        return $result;
     }
 }

tests/Requests/PostEvent/JobDataTest.php

@@ -40,4 +40,60 @@ public function testJsonSerialize(): void
             $jobData->jsonSerialize()
         );
     }
+
+    public function testJsonSerializeEmptyConfigurationId(): void
+    {
+        $jobData = new JobData(
+            '23456',
+            'http://someUrl',
+            '2020-01-01',
+            '2020-02-02',
+            'keboola.orchestrator',
+            'Orchestrator',
+            null,
+            'My configuration'
+        );
+        self::assertSame(
+            [
+                'id' => '23456',
+                'url' => 'http://someUrl',
+                'startTime' => '2020-01-01',
+                'endTime' => '2020-02-02',
+                'component' => [
+                    'id' => 'keboola.orchestrator',
+                    'name' => 'Orchestrator',
+                ],
+                'tasks' => [],
+            ],
+            $jobData->jsonSerialize()
+        );
+    }
+
+    public function testJsonSerializeEmptyConfigurationName(): void
+    {
+        $jobData = new JobData(
+            '23456',
+            'http://someUrl',
+            '2020-01-01',
+            '2020-02-02',
+            'keboola.orchestrator',
+            'Orchestrator',
+            '1234',
+            null
+        );
+        self::assertSame(
+            [
+                'id' => '23456',
+                'url' => 'http://someUrl',
+                'startTime' => '2020-01-01',
+                'endTime' => '2020-02-02',
+                'component' => [
+                    'id' => 'keboola.orchestrator',
+                    'name' => 'Orchestrator',
+                ],
+                'tasks' => [],
+            ],
+            $jobData->jsonSerialize()
+        );
+    }
 }