Skip to content

Commit a7aa7bd

Browse files
committed
readme fix
1 parent af8528c commit a7aa7bd

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,18 +113,19 @@ $clientFactory->getEventsClient('xxx-xxxxx-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
113113
SERVICE_PRINCIPAL_ID=$(az ad sp list --display-name testing-notification-api-php-client --query "[0].objectId" --output tsv)
114114
```
115115

116-
- Deploy the key vault, provide tenant ID, service principal ID and group ID from the previous commands:
116+
- Deploy the Storage Account for logs, provide tenant ID, service principal ID and group ID from the previous commands:
117117
```bash
118118
az deployment group create --resource-group testing-notification-api-php-client --template-file provisioning/azure.json --parameters vault_name=test-notification-client tenant_id=$TEST_AZURE_TENANT_ID service_principal_object_id=$SERVICE_PRINCIPAL_ID
119119
```
120120

121-
- Show Key Vault URL
121+
- Get the connection string
122122
```bash
123-
az keyvault show --name test-notification-client --query "properties.vaultUri" --output tsv
123+
az storage account show-connection-string -g testing-notification-api-php-client -n mirontfcnacc2 --query "connectionString" --output tsv
124124
```
125125

126-
returns e.g. `https://test-job-queue-client.vault.azure.net/`, use this to set values in `set-env.sh` file:
127-
- `test_azure_key_vault_url` - https://test-job-queue-client.vault.azure.net/
126+
Set the connection string and container name you provided as parameter to the create command to following environment variables in the `set-env.sh` file:
127+
- AZURE_LOGS_ABS_CONTAINER
128+
- AZURE_LOGS_ABS_CONNECTION_STRING
128129

129130
## Generate environment configuration
130131

0 commit comments

Comments
 (0)