feat: Get rid of myclabs/php-enum, switch to native enums

Author: pepamartinec

composer.json

@@ -28,7 +28,6 @@
         "php": "^8.2",
         "ext-json": "*",
         "guzzlehttp/guzzle": "^6.3|^7.2",
-        "myclabs/php-enum": "^1.8",
         "psr/log": "^2|^3",
         "symfony/validator": "^6.4|^7.0"
     },

src/Requests/PostSubscription/Filter.php

@@ -27,7 +27,7 @@ public function jsonSerialize(): array
         ];
 
         if ($this->operator !== null) {
-            $data['operator'] = $this->operator->getValue();
+            $data['operator'] = $this->operator->value;
         }
 
         return $data;

src/Requests/PostSubscription/FilterOperator.php

@@ -4,30 +4,11 @@
 
 namespace Keboola\NotificationClient\Requests\PostSubscription;
 
-use DomainException;
-use MyCLabs\Enum\Enum;
-
-/**
- * @method static self EQUAL()
- * @method static self LESS_THAN()
- * @method static self GREATER_THAN()
- * @method static self LESS_THAN_OR_EQUAL()
- * @method static self GREATER_THAN_OR_EQUAL()
- *
- * @phpstan-extends Enum<string>
- */
-class FilterOperator extends Enum
+enum FilterOperator: string
 {
-    // phpcs:disable SlevomatCodingStandard.Classes.UnusedPrivateElements
-    // @phpstan-ignore-next-line
-    private const EQUAL = '=='; // can't be called EQUALS because there is a method called `equals` on base Enum class
-    // @phpstan-ignore-next-line
-    private const LESS_THAN = '<';
-    // @phpstan-ignore-next-line
-    private const GREATER_THAN = '>';
-    // @phpstan-ignore-next-line
-    private const LESS_THAN_OR_EQUAL = '<=';
-    // @phpstan-ignore-next-line
-    private const GREATER_THAN_OR_EQUAL = '>=';
-    // phpcs:enable SlevomatCodingStandard.Classes.UnusedPrivateElements
+    case Equal = '==';
+    case LessThan = '<';
+    case GreaterThan = '>';
+    case LessThanOrEqual = '<=';
+    case GreaterThanOrEqual = '>=';
 }

tests/Requests/PostSubscription/FilterOperatorTest.php

@@ -14,15 +14,15 @@ class FilterOperatorTest extends TestCase
      */
     public function testOperatorValues(FilterOperator $operator, string $expectedValue): void
     {
-        self::assertSame($expectedValue, $operator->getValue());
+        self::assertSame($expectedValue, $operator->value);
     }
 
     public function provideOperatorValues(): iterable
     {
-        yield 'equals' => [FilterOperator::EQUAL(), '=='];
-        yield 'less than' => [FilterOperator::LESS_THAN(), '<'];
-        yield 'greater than' => [FilterOperator::GREATER_THAN(), '>'];
-        yield 'less than or equals' => [FilterOperator::LESS_THAN_OR_EQUAL(), '<='];
-        yield 'greater than or equals' => [FilterOperator::GREATER_THAN_OR_EQUAL(), '>='];
+        yield 'equals' => [FilterOperator::Equal, '=='];
+        yield 'less than' => [FilterOperator::LessThan, '<'];
+        yield 'greater than' => [FilterOperator::GreaterThan, '>'];
+        yield 'less than or equals' => [FilterOperator::LessThanOrEqual, '<='];
+        yield 'greater than or equals' => [FilterOperator::GreaterThanOrEqual, '>='];
     }
 }

tests/Requests/PostSubscription/FilterTest.php

@@ -24,7 +24,7 @@ public function testJsonSerialize(): void
 
     public function testJsonSerializeWithOperator(): void
     {
-        $filter = new Filter('someName', 'someValue', FilterOperator::GREATER_THAN_OR_EQUAL());
+        $filter = new Filter('someName', 'someValue', FilterOperator::GreaterThanOrEqual);
         self::assertSame(
             [
                 'field' => 'someName',