Skip to content

Commit f710db4

Browse files
committed
feat: Bump psr/log to v2+
1 parent 2947d56 commit f710db4

4 files changed

Lines changed: 36 additions & 20 deletions

File tree

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,13 @@
2929
"ext-json": "*",
3030
"guzzlehttp/guzzle": "^6.3|^7.2",
3131
"myclabs/php-enum": "^1.8",
32-
"psr/log": "^1.1",
32+
"psr/log": "^2|^3",
3333
"symfony/validator": "^5.2|^6.0"
3434
},
3535
"require-dev": {
3636
"infection/infection": "^0.26",
3737
"keboola/coding-standard": ">=14.0",
38+
"monolog/monolog": "^3.9",
3839
"phpstan/phpstan": "^1.8",
3940
"phpstan/phpstan-phpunit": "^1.1",
4041
"phpunit/phpunit": "^9.5",

tests/ClientFactoryTest.php

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@
1313
use Keboola\NotificationClient\EventsClient;
1414
use Keboola\NotificationClient\NotificationsClient;
1515
use Keboola\NotificationClient\SubscriptionClient;
16+
use Monolog\Handler\TestHandler;
17+
use Monolog\Logger;
1618
use PHPUnit\Framework\TestCase;
17-
use Psr\Log\Test\TestLogger;
1819

1920
class ClientFactoryTest extends TestCase
2021
{
@@ -55,7 +56,9 @@ public function testGetClient(): void
5556
$history = Middleware::history($requestHistory);
5657
$stack = HandlerStack::create($mock);
5758
$stack->push($history);
58-
$logger = new TestLogger();
59+
60+
$logsHandler = new TestHandler();
61+
$logger = new Logger('test', [$logsHandler]);
5962

6063
$clientFactory = new ClientFactory(
6164
'https://dummy',
@@ -77,8 +80,8 @@ public function testGetClient(): void
7780
/** @var Request $request */
7881
$request = $requestHistory[0]['request'];
7982
self::assertSame('test agent', $request->getHeader('User-Agent')[0]);
80-
self::assertTrue($logger->hasDebugThatContains('"GET /1.1" 200 '));
81-
self::assertTrue($logger->hasDebugThatContains('test agent'));
83+
self::assertTrue($logsHandler->hasDebugThatContains('"GET /1.1" 200 '));
84+
self::assertTrue($logsHandler->hasDebugThatContains('test agent'));
8285
}
8386

8487
public function testGetClientLazy(): void
@@ -94,7 +97,9 @@ public function testGetClientLazy(): void
9497
$history = Middleware::history($requestHistory);
9598
$stack = HandlerStack::create($mock);
9699
$stack->push($history);
97-
$logger = new TestLogger();
100+
101+
$logsHandler = new TestHandler();
102+
$logger = new Logger('test', [$logsHandler]);
98103

99104
$clientFactory = new ClientFactory(
100105
'https://dummy',

tests/ClientTest.php

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,10 @@
1515
use Keboola\NotificationClient\Requests\Event;
1616
use Keboola\NotificationClient\Requests\PostEvent\JobData;
1717
use Keboola\NotificationClient\Requests\PostEvent\JobFailedEventData;
18+
use Monolog\Handler\TestHandler;
19+
use Monolog\Logger;
1820
use PHPUnit\Framework\TestCase;
1921
use Psr\Log\LoggerInterface;
20-
use Psr\Log\Test\TestLogger;
2122

2223
class ClientTest extends TestCase
2324
{
@@ -182,7 +183,10 @@ public function testLogger(): void
182183
$history = Middleware::history($requestHistory);
183184
$stack = HandlerStack::create($mock);
184185
$stack->push($history);
185-
$logger = new TestLogger();
186+
187+
$logsHandler = new TestHandler();
188+
$logger = new Logger('test', [$logsHandler]);
189+
186190
$client = $this->getClient(
187191
[
188192
'handler' => $stack,
@@ -195,8 +199,8 @@ public function testLogger(): void
195199
/** @var Request $request */
196200
$request = $requestHistory[0]['request'];
197201
self::assertSame('test agent', $request->getHeader('User-Agent')[0]);
198-
self::assertTrue($logger->hasDebugThatContains('"POST /1.1" 200 '));
199-
self::assertTrue($logger->hasDebugThatContains('test agent'));
202+
self::assertTrue($logsHandler->hasDebugThatContains('"POST /1.1" 200 '));
203+
self::assertTrue($logsHandler->hasDebugThatContains('test agent'));
200204
}
201205

202206
public function testRetrySuccess(): void
@@ -234,7 +238,10 @@ public function testRetrySuccess(): void
234238
$history = Middleware::history($requestHistory);
235239
$stack = HandlerStack::create($mock);
236240
$stack->push($history);
237-
$logger = new TestLogger();
241+
242+
$logsHandler = new TestHandler();
243+
$logger = new Logger('test', [$logsHandler]);
244+
238245
$client = $this->getClient(
239246
[
240247
'handler' => $stack,
@@ -252,7 +259,7 @@ public function testRetrySuccess(): void
252259
self::assertSame('https://example.com/events/job-failed', $request->getUri()->__toString());
253260
$request = $requestHistory[2]['request'];
254261
self::assertSame('https://example.com/events/job-failed', $request->getUri()->__toString());
255-
self::assertTrue($logger->hasNoticeThatContains('retrying'));
262+
self::assertTrue($logsHandler->hasNoticeThatContains('retrying'));
256263
}
257264

258265
public function testRetryFailure(): void
@@ -271,7 +278,10 @@ public function testRetryFailure(): void
271278
$history = Middleware::history($requestHistory);
272279
$stack = HandlerStack::create($mock);
273280
$stack->push($history);
274-
$logger = new TestLogger();
281+
282+
$logsHandler = new TestHandler();
283+
$logger = new Logger('test', [$logsHandler]);
284+
275285
$client = $this->getClient(
276286
['handler' => $stack, 'backoffMaxTries' => 1, 'userAgent' => 'Test', 'logger' => $logger],
277287
);
@@ -282,7 +292,7 @@ public function testRetryFailure(): void
282292
self::assertStringContainsString('500 Internal Server Error', $e->getMessage());
283293
}
284294
self::assertCount(2, $requestHistory);
285-
self::assertTrue($logger->hasNoticeThatContains('We have tried this 1 times. Giving up.'));
295+
self::assertTrue($logsHandler->hasNoticeThatContains('We have tried this 1 times. Giving up.'));
286296
}
287297

288298
public function testNoRetry(): void

tests/StorageApiIndexClientTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,10 @@
1111
use GuzzleHttp\Psr7\Request;
1212
use GuzzleHttp\Psr7\Response;
1313
use Keboola\NotificationClient\Exception\ClientException;
14-
use Keboola\NotificationClient\Requests\PostSubscription\EmailRecipient;
15-
use Keboola\NotificationClient\Requests\PostSubscription\Filter;
16-
use Keboola\NotificationClient\Requests\Subscription;
1714
use Keboola\NotificationClient\StorageApiIndexClient;
18-
use Keboola\NotificationClient\SubscriptionClient;
15+
use Monolog\Handler\TestHandler;
16+
use Monolog\Logger;
1917
use PHPUnit\Framework\TestCase;
20-
use Psr\Log\Test\TestLogger;
2118

2219
class StorageApiIndexClientTest extends TestCase
2320
{
@@ -49,7 +46,10 @@ public function testInvalidResponse(string $responseData, string $expectedError)
4946
$history = Middleware::history($requestHistory);
5047
$stack = HandlerStack::create($mock);
5148
$stack->push($history);
52-
$logger = new TestLogger();
49+
50+
$logsHandler = new TestHandler();
51+
$logger = new Logger('test', [$logsHandler]);
52+
5353
$client = new StorageApiIndexClient(
5454
'https://dummy',
5555
['handler' => $stack, 'logger' => $logger, 'backoffMaxTries' => 3, 'userAgent' => 'Test'],

0 commit comments

Comments
 (0)