refactor: AJDA-2680 rename detailSubscription() to getSubscription()

Author: ondrajodas

README.md

@@ -70,7 +70,7 @@ foreach ($subscriptions as $subscription) {
 }
 
 // fetch a single subscription by ID
-$detail = $subscriptionClient->detailSubscription($created->getId());
+$subscription = $subscriptionClient->getSubscription($created->getId());
 
 // delete a subscription
 $subscriptionClient->deleteSubscription($created->getId());

src/SubscriptionClient.php

@@ -51,7 +51,7 @@ public function deleteSubscription(string $id): void
         $this->sendRequest($request);
     }
 
-    public function detailSubscription(string $id): ResponseSubscription
+    public function getSubscription(string $id): ResponseSubscription
     {
         $request = new Request(
             'GET',

tests/SubscriptionClientFunctionalTest.php

@@ -146,7 +146,7 @@ public function testDeleteSubscriptionHeaders(): void
         );
     }
 
-    public function testDetailSubscriptionHeaders(): void
+    public function testGetSubscriptionHeaders(): void
     {
         $mock = new MockHandler([
             new Response(
@@ -172,7 +172,7 @@ public function testDetailSubscriptionHeaders(): void
             ['handler' => $stack, 'backoffMaxTries' => 3, 'userAgent' => 'Test'],
         );
 
-        $result = $client->detailSubscription('subscription-123');
+        $result = $client->getSubscription('subscription-123');
 
         /** @var Request $request */
         $request = $requestHistory[0]['request'];
@@ -262,10 +262,10 @@ public function testListAndDeleteSubscriptionLifecycle(): void
         ));
         self::assertNotEmpty($created->getId());
 
-        // detail — must return the same subscription
-        $detail = $client->detailSubscription($created->getId());
-        self::assertSame($created->getId(), $detail->getId());
-        self::assertSame('job-failed', $detail->getEvent());
+        // get — must return the same subscription
+        $fetched = $client->getSubscription($created->getId());
+        self::assertSame($created->getId(), $fetched->getId());
+        self::assertSame('job-failed', $fetched->getEvent());
 
         // list — must contain the new subscription
         $beforeDelete = $client->listSubscriptions();