Merge pull request #88 from keboola/jirka-ter-58-add-drop-column

TER-58 Add/drop column

Author: romanbracinik

src/Table/Teradata/TeradataTableQueryBuilder.php

@@ -60,6 +60,27 @@ public function getTruncateTableCommand(string $schemaName, string $tableName):
         );
     }
 
+    public function getAddColumnCommand(string $schemaName, string $tableName, TeradataColumn $columnDefinition): string
+    {
+        return sprintf(
+            'ALTER TABLE %s.%s ADD %s %s',
+            TeradataQuote::quoteSingleIdentifier($schemaName),
+            TeradataQuote::quoteSingleIdentifier($tableName),
+            TeradataQuote::quoteSingleIdentifier($columnDefinition->getColumnName()),
+            $columnDefinition->getColumnDefinition()->getSQLDefinition()
+        );
+    }
+
+    public function getDropColumnCommand(string $schemaName, string $tableName, string $columnName): string
+    {
+        return sprintf(
+            'ALTER TABLE %s.%s DROP %s',
+            TeradataQuote::quoteSingleIdentifier($schemaName),
+            TeradataQuote::quoteSingleIdentifier($tableName),
+            TeradataQuote::quoteSingleIdentifier($columnName)
+        );
+    }
+
     /**
      * @inheritDoc
      */

tests/Functional/Teradata/Table/TeradataTableQueryBuilderTest.php

@@ -132,6 +132,54 @@ public function testGetCreateCommand(
         self::assertSame($expectedPKs, $tableReflection->getPrimaryKeysNames());
     }
 
+    public function testAddAndDropColumn(): void
+    {
+        $dbName = $this->getDatabaseName();
+        $columns = [TeradataColumn::createGenericColumn('col1'),
+            TeradataColumn::createGenericColumn('col2')];
+        $sql = $this->qb->getCreateTableCommand(
+            $this->getDatabaseName(),
+            self::TABLE_GENERIC,
+            new ColumnCollection($columns),
+        );
+        $this->connection->executeQuery($sql);
+
+        // add column
+        $sql = $this->qb->getAddColumnCommand(
+            $dbName,
+            self::TABLE_GENERIC,
+            TeradataColumn::createGenericColumn('col3')
+        );
+        $this->assertEquals(
+            sprintf(
+                'ALTER TABLE "%s"."%s" ADD "col3" VARCHAR (32000) NOT NULL DEFAULT \'\' CHARACTER SET UNICODE',
+                $dbName,
+                self::TABLE_GENERIC
+            ),
+            $sql
+        );
+        $this->connection->executeQuery($sql);
+
+        $tableReflection = new TeradataTableReflection(
+            $this->connection,
+            $this->getDatabaseName(),
+            self::TABLE_GENERIC
+        );
+        self::assertSame(['col1', 'col2', 'col3'], $tableReflection->getColumnsNames());
+
+        // drop column
+        $sql = $this->qb->getDropColumnCommand($dbName, self::TABLE_GENERIC, 'col2');
+        $this->assertEquals(sprintf('ALTER TABLE "%s"."%s" DROP "col2"', $dbName, self::TABLE_GENERIC), $sql);
+        $this->connection->executeQuery($sql);
+
+        $tableReflection = new TeradataTableReflection(
+            $this->connection,
+            $this->getDatabaseName(),
+            self::TABLE_GENERIC
+        );
+        self::assertSame(['col1', 'col3'], $tableReflection->getColumnsNames());
+    }
+
     /**
      * @return \Generator<string, mixed, mixed, mixed>
      */