Skip to content

Commit 4f8e8a2

Browse files
committed
fix: Change quoting in array shape PHPDoc
Why? PHPStorm was unable to correctly parse the meaning of 'null?'. With single quotes, he thought the "?" stands for the optional array key instead of string key "null?".
1 parent 64871f2 commit 4f8e8a2

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

src/Column/Snowflake/SnowflakeColumn.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function getColumnDefinition(): DefinitionInterface
5454
* name: string,
5555
* type: string,
5656
* default: string,
57-
* 'null?': string
57+
* "null?": string,
5858
* } $dbResponse
5959
*/
6060
public static function createFromDB(array $dbResponse): SnowflakeColumn

src/Table/Snowflake/SnowflakeTableReflection.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,16 @@ public function getColumnsNames(): array
118118
public function getColumnsDefinitions(): ColumnCollection
119119
{
120120
$this->cacheTableProps();
121-
/** @var array<array{
121+
122+
/**
123+
* @var array<array{
122124
* name: string,
123125
* kind: string,
124126
* type: string,
125127
* default: string,
126-
* 'null?': string
127-
* }> $columnsMeta */
128+
* "null?": string,
129+
* }> $columnsMeta
130+
*/
128131
$columnsMeta = $this->connection->fetchAllAssociative(
129132
sprintf(
130133
'DESC TABLE %s',

0 commit comments

Comments
 (0)